Mir

Code review comment for lp:~mlankhorst/mir/setsid

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Looks good from a functionality perspective. Some style nits:

8 + if (activate) {

opening brace on its own line

10 + BOOST_THROW_EXCEPTION(
11 + boost::enable_error_info(
12 + std::runtime_error("Failed to stop being a process group"))
13 + << boost::errinfo_errno(errno));

17 + BOOST_THROW_EXCEPTION(
18 + boost::enable_error_info(
19 + std::runtime_error("Failed to become session leader"))
20 + << boost::errinfo_errno(errno));

Multi-line statements in 'if' clauses should be placed in curly braces.

review: Needs Fixing

« Back to merge proposal