Merge lp:~mkoppanen/libmemcached/replication-miss-test into lp:~tangent-org/libmemcached/trunk

[mikko]

[mikko (mkoppanen)]

Hi, here is a test for replication misses. The comments should explain it but if you have issues let me know

Unmerged revisions

778. By Mikko Koppanen <email address hidden> on 2010-02-10

added test

=== modified file 'tests/mem_functions.c'
--- tests/mem_functions.c	2010-01-22 22:41:53 +0000
+++ tests/mem_functions.c	2010-02-10 21:56:15 +0000
@@ -4439,6 +4439,66 @@
   return TEST_SUCCESS;
 }
 
+/* Test that single miss does not cause replica reads to fail */
+static test_return_t replication_miss_test(memcached_st *memc)
+{
+  memcached_return_t rc;
+  memcached_st *memc_repl= memcached_clone(NULL, memc);
+  memcached_st *memc_single= memcached_clone(NULL, memc);
+
+  char *v;
+  const char *key   = "hello_w_k";
+  const char *value = "my_value";
+  size_t vlen;
+  uint32_t flags;
+
+  /* this test makes sense only with 2 or more servers */
+  test_true(memcached_server_count(memc_repl) > 1);
+
+  /* Consistent hash */
+  memcached_behavior_set(memc_repl, MEMCACHED_DISTRIBUTION_CONSISTENT, 1);
+  memcached_behavior_set(memc_single, MEMCACHED_DISTRIBUTION_CONSISTENT, 1);
+
+  /* The first clone writes to all servers */
+  memcached_behavior_set(memc_repl, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL, 1);
+  memcached_behavior_set(memc_repl, MEMCACHED_BEHAVIOR_NUMBER_OF_REPLICAS, 
+                         memcached_server_count(memc_repl));
+
+  /* Write to servers */
+  rc= memcached_set(memc_repl, key, strlen(key), 
+                               value, strlen(value), 
+                               (time_t)1200, (uint32_t)0);
+  test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED);
+
+  /* Use the second clone to remove the key from primary server.
+      This should remove the key from only one server */
+  rc= memcached_delete(memc_single, key, strlen(key), 0);
+  test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED);
+  
+  /* Remove the server where the key was deleted */
+  memcached_server_st *instance= memcached_server_by_key(memc_single, key, strlen(key), &rc);
+  test_true(rc == MEMCACHED_SUCCESS);
+  rc= memcached_server_remove(instance);
+  test_true(rc == MEMCACHED_SUCCESS);
+  
+  /* Test that others still have it */
+  v= memcached_get(memc_single, key, strlen(key), &vlen, &flags, &rc);
+  test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED);
+  test_true(v && strcmp(v, value) == 0);
+  free(v);
+
+  /* This read should still return the value as we have it on other servers */
+  v= memcached_get(memc_repl, key, strlen(key), &vlen, &flags, &rc);
+  test_true(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED);
+  test_true(v && strcmp(v, value) == 0);
+  free(v);
+  
+  memcached_free(memc_repl);
+  memcached_free(memc_single);
+
+  return TEST_SUCCESS;
+}
+
 static test_return_t replication_delete_test(memcached_st *memc)
 {
   memcached_return_t rc;
@@ -5995,6 +6055,7 @@
   {"set", 1, (test_callback_fn)replication_set_test },
   {"get", 0, (test_callback_fn)replication_get_test },
   {"mget", 0, (test_callback_fn)replication_mget_test },
+  {"miss", 0, (test_callback_fn)replication_miss_test},
   {"delete", 0, (test_callback_fn)replication_delete_test },
   {"rand_mget", 0, (test_callback_fn)replication_randomize_mget_test },
   {0, 0, (test_callback_fn)0}