lp:~mkindahl/drizzle/stdize-code
There are several macros, function, and other nifty objects that already exist in the C++ standard. The goal is to replace some of the more obvious cases with standard versions.
- Get this branch:
- bzr branch lp:~mkindahl/drizzle/stdize-code
Branch merges
- No reviews requested
Related bugs
Related blueprints
Branch information
Recent revisions
- 327. By Mats Kindahl
-
Replaced use of thd_proc_info() macro with calls to
set_proc_info() and get_proc_info() internally. Introduced
functions set_thd_proc_info() and get_thd_proc_info() for
external users, i.e., plug-ins.The set_thd_proc_info() accepted callers info that can be used to
print debug output, but the information was not used. The return
value was changed to void and the old value is not fetched any
more. To be able to get the value of proc_info for external
users, the function get_thd_proc_info() was introduced.The thd_proc_info() macro called set_thd_proc_info() but almost
never used the return value of set_thd_proc_info() so the macro
was replaced with a call of THD::set_proc_info( ). - 326. By Mats Kindahl
-
Post-merge fix to new code using THD:proc_info, which was made private by the pre-merge patch.
- 324. By Mats Kindahl
-
Hiding THD::proc_info field and providing a setter and getter.
Replacing use of swap_variables() in C++ code with std::swap().
Moving swap_variables() into C files where it is used.
Replacing some function-like macros with inline functions. - 323. By Mats Kindahl
-
Turning on -O3 for non-debug builds since this enabled function inlining.
It also enabled the optimizations -funswitch-loops and -fgcse-after-reload.
The optimization -funswitch-loops moves invariant code out of loop bodies,
while -fgcse-after-reload does an extra pass to elimiate redundant loads.
Both optimization have potential for speeding up the code, but low risk of
breaking anything.
Branch metadata
- Branch format:
- Branch format 6
- Repository format:
- Bazaar pack repository format 1 (needs bzr 0.92)