Compiz

Merge lp:~mkhu/compiz/fix_workarounds_plugin_typo_0.9.9 into lp:compiz/0.9.9

  1. fix_workarounds_plugin_typo_0.9.9
  2. Merge into 0.9.9
Proposed by Micheal Hsu
Status: Rejected
Rejected by: Stephen M. Webb
Proposed branch: lp:~mkhu/compiz/fix_workarounds_plugin_typo_0.9.9
Merge into: lp:compiz/0.9.9
Diff against target: 12 lines (+1/-1)
1 file modified
plugins/workarounds/src/workarounds.cpp (+1/-1)
To merge this branch: bzr merge lp:~mkhu/compiz/fix_workarounds_plugin_typo_0.9.9
Reviewer Review Type Date Requested Status
Stephen M. Webb Disapprove
Marco Trevisan (Treviño) Pending
Review via email: mp+163942@code.launchpad.net

Commit message

workarounds.cpp: Fix typo in call to XShapeSelectInput.

(LP: #1167284)

Description of the change

in workarounds.cpp:

WorkaroundsWindow::clearInputShape (..)
{
...
XShapeSelectInput (screen->dpy (), xid, ShapeNotify);

}

ShapeNotify is the event code. it should be changed to ShapeNotifyMask here.

To post a comment you must log in.
lp:~mkhu/compiz/fix_workarounds_plugin_typo_0.9.9 updated
3657. By Micheal Hsu

workarounds plugin: fix a typo (change ShapeNotify to ShapeNotifyMask in XShapeSelectInput)

Revision history for this message
Stephen M. Webb (bregma) wrote :

0.9.9 branch is no longer maintained

review: Disapprove

Unmerged revisions

3657. By Micheal Hsu

workarounds plugin: fix a typo (change ShapeNotify to ShapeNotifyMask in XShapeSelectInput)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/workarounds/src/workarounds.cpp'
2--- plugins/workarounds/src/workarounds.cpp 2012-12-10 03:28:47 +0000
3+++ plugins/workarounds/src/workarounds.cpp 2013-05-15 13:35:14 +0000
4@@ -72,7 +72,7 @@
5 XShapeCombineRectangles (screen->dpy (), xid, ShapeInput, 0, 0,
6 NULL, 0, ShapeSet, 0);
7
8- XShapeSelectInput (screen->dpy (), xid, ShapeNotify);
9+ XShapeSelectInput (screen->dpy (), xid, ShapeNotifyMask);
10 }
11
12 /*

Subscribers

People subscribed via source and target branches