lp:~mixxxdevelopers/mixxx/qt3-removal

Created by Albert Santoni and last modified

Removes Mixxx's dependency on the Qt3Support library in Qt 4. Marks the final completion of our port to Qt4.

Currently needs testing to find bugs and fix them.

Things that need really thorough testing:
- MP3 playback, especially seeking and cueing
- BPM detection
- Check for memory leaks
- Skin changing, colour scheme changing
- MIDI mapping XML loading, saving
- Keyboard control

Get this branch:
bzr branch lp:~mixxxdevelopers/mixxx/qt3-removal
Members of Mixxx Development Team can upload to this branch. Log in for directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Mixxx Development Team
Project:
Mixxx
Status:
Merged

Recent revisions

2427. By Albert Santoni

* Removed Qt3Support from SConscript and everywhere else I could find.
* Changed a ton of Q3PtrLists over into QList<blah*>, checked for use of setAutoDelete() and made sure that the behaviour of that was replicated with extra code to manually delete pointers on removal.
* Ditto for Q3PtrQueue.
* Changed a bunch of iterators in places where the built-in Q3PtrList iterators were used over to Qt4's Java style iterators, which are waaaaaay safer to use.
* Removed some Q3GroupBoxes from the preferences dialog.
* Removed most (all?) the QT3_SUPPORT #ifdefs.
* Removed all the #includes for Qt3 headers
* Fixed Parser, ParserM3U, and ParserPLS because they were broken all over the place. Rewrote a lot of code there, replaced a bunch of good for nothing pointers with references, fixed some file handle leaks, etc etc.

2426. By RJ Skerry-Ryan

Merging from trunk.

2425. By Albert Santoni

Make the VBR MP3 duration calculation on track load update the TIOs. Perform a fast estimate in ParseHeader().

2424. By Albert Santoni

Fixed a possible divide by zero on weirdo MP3s

2423. By RJ Skerry-Ryan

Version bump to 1.8.0~beta2.

2422. By RJ Skerry-Ryan

Add an EngineWorker framework for allowing EngineChannels to provide runnable's to be run when the audio callback is done. Convert CachingReader to be run via this framework to consolidate the readers into one thread and help ensure that they do not run while the callback is active.

2421. By Albert Santoni

Uncommented a transaction rollback that I accidentally committed...

2420. By Albert Santoni

Fixed deleted and moved file detection

2419. By RJ Skerry-Ryan

Fix a bug that resulted in all legacy-tracks imports to fail. The track ID was being set from mixxxtrack.xml, which caused TrackDao to update the track instead of save since it thought the track had already been saved (id != -1). Also, add conversion of legacy track cue points to new cue points, which resolved LP Bug #527563. Make TrackDao::updateTrack check for the number of affected rows and rollback if 0 are affected. Fixed a bug that caused new cue points to be instantly deleted.

2418. By RJ Skerry-Ryan

Fix TrackInfoObject constructor from-QDomNode constructor to make its lock recursive. This was an oversight which causes deadlocks in the legacy library importer.

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:~mixxxdevelopers/mixxx/trunk
This branch contains Public information 
Everyone can see this information.

Subscribers