Merge lp:~mitya57/unity-greeter/flashback-names into lp:unity-greeter

Proposed by Dmitry Shachnev
Status: Merged
Merged at revision: 1441
Proposed branch: lp:~mitya57/unity-greeter/flashback-names
Merge into: lp:unity-greeter
Diff against target: 14 lines (+1/-3)
1 file modified
src/session-list.vala (+1/-3)
To merge this branch: bzr merge lp:~mitya57/unity-greeter/flashback-names
Reviewer Review Type Date Requested Status
Unity Greeter Development Team Pending
Review via email: mp+242205@code.launchpad.net

Description of the change

We finally reached some consistency in GNOME Flashback and our sessions are now named:

- gnome-flashback-metacity
- gnome-flashback-compiz

To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Should we keep the old names in the switch and mark as legacy?

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

I don't see the point in doing so. Most people are using distro shipped Unity Greeter, which will have old entries in old Ubuntu versions.

After all, it is just an icon.

Revision history for this message
Robert Ancell (robert-ancell) wrote :

OK, just wanted to check if there might be a migration issue. Thanks Dmitry!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/session-list.vala'
2--- src/session-list.vala 2013-08-08 13:19:04 +0000
3+++ src/session-list.vala 2014-11-19 13:14:30 +0000
4@@ -101,9 +101,7 @@
5 return "ubuntu_badge.png";
6 case "gnome-classic":
7 case "gnome-flashback-compiz":
8- case "gnome-flashback":
9- case "gnome-fallback-compiz":
10- case "gnome-fallback":
11+ case "gnome-flashback-metacity":
12 case "gnome-shell":
13 case "gnome":
14 return "gnome_badge.png";

Subscribers

People subscribed via source and target branches