Merge lp:~mitya57/ubuntu/precise/marble/lp1049473 into lp:ubuntu/precise-proposed/marble

Proposed by Dmitry Shachnev
Status: Merged
Merge reported by: Sebastien Bacher
Merged at revision: not available
Proposed branch: lp:~mitya57/ubuntu/precise/marble/lp1049473
Merge into: lp:ubuntu/precise-proposed/marble
Diff against target: 480 lines (+438/-0)
6 files modified
.pc/add-missing-header.diff/src/lib/CMakeLists.txt (+415/-0)
.pc/applied-patches (+1/-0)
debian/changelog (+6/-0)
debian/patches/add-missing-header.diff (+14/-0)
debian/patches/series (+1/-0)
src/lib/CMakeLists.txt (+1/-0)
To merge this branch: bzr merge lp:~mitya57/ubuntu/precise/marble/lp1049473
Reviewer Review Type Date Requested Status
Ubuntu Development Team Pending
Review via email: mp+156256@code.launchpad.net

Description of the change

This fixes bug 1049473 by backporting a trivial one-line fix that is already applied in Quantal+ and upstream.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks for your work

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory '.pc/add-missing-header.diff'
2=== added directory '.pc/add-missing-header.diff/src'
3=== added directory '.pc/add-missing-header.diff/src/lib'
4=== added file '.pc/add-missing-header.diff/src/lib/CMakeLists.txt'
5--- .pc/add-missing-header.diff/src/lib/CMakeLists.txt 1970-01-01 00:00:00 +0000
6+++ .pc/add-missing-header.diff/src/lib/CMakeLists.txt 2013-03-30 11:11:23 +0000
7@@ -0,0 +1,415 @@
8+PROJECT(marblewidget)
9+
10+if (QTONLY)
11+ cmake_minimum_required(VERSION 2.4.0)
12+endif (QTONLY)
13+
14+
15+INCLUDE_DIRECTORIES(
16+ ${CMAKE_SOURCE_DIR}/src/lib
17+ ${CMAKE_BINARY_DIR}/src/lib
18+ ${CMAKE_CURRENT_SOURCE_DIR}/Projections
19+ ${CMAKE_CURRENT_SOURCE_DIR}/routing
20+ ${CMAKE_CURRENT_SOURCE_DIR}/geodata
21+ ${CMAKE_CURRENT_SOURCE_DIR}/geodata/data
22+ ${CMAKE_CURRENT_SOURCE_DIR}/geodata/graphicsitem
23+ ${CMAKE_CURRENT_SOURCE_DIR}/geodata/scene
24+ ${CMAKE_CURRENT_SOURCE_DIR}/geodata/handlers
25+ ${CMAKE_CURRENT_SOURCE_DIR}/geodata/handlers/kml
26+ ${CMAKE_CURRENT_SOURCE_DIR}/geodata/handlers/dgml
27+ ${CMAKE_CURRENT_SOURCE_DIR}/geodata/parser
28+ ${CMAKE_CURRENT_SOURCE_DIR}/graphicsview
29+ ${CMAKE_CURRENT_SOURCE_DIR}/layers
30+ ${QT_INCLUDE_DIR}
31+)
32+INCLUDE(${QT_USE_FILE})
33+INCLUDE(geodata/CMakeLists.txt)
34+INCLUDE(graphicsview/CMakeLists.txt)
35+INCLUDE(layers/CMakeLists.txt)
36+
37+set(GENERIC_LIB_VERSION "0.13.0")
38+set(GENERIC_LIB_SOVERSION "13")
39+
40+if (QTONLY)
41+ # ce: don't know why this is needed here - on win32 'O2' is activated by default in release mode
42+ if(NOT WIN32)
43+ add_definitions (${QT_DEFINITIONS} -O3)
44+ endif(NOT WIN32)
45+
46+ include_directories(
47+ ${QT_INCLUDE_DIR}
48+ )
49+else (QTONLY)
50+ if(NOT WIN32)
51+ add_definitions (${QT_DEFINITIONS} ${KDE4_DEFINITIONS} -O3)
52+ endif(NOT WIN32)
53+
54+ include_directories(
55+ ${KDE4_INCLUDES}
56+ )
57+endif (QTONLY)
58+
59+# link_directories (${QT_LIBRARY_DIR})
60+########### next target ###############
61+
62+set(marblewidget_SRCS
63+ ${geodata_SRCS}
64+ ${graphicsview_SRCS}
65+ ${screengraphicsitem_SRCS}
66+ ${layers_SRCS}
67+ blendings/Blending.cpp
68+ blendings/BlendingAlgorithms.cpp
69+ blendings/BlendingFactory.cpp
70+ blendings/SunLightBlending.cpp
71+ DownloadRegionDialog.cpp
72+ LatLonBoxWidget.cpp
73+ MarbleWidget.cpp
74+ MarbleModel.cpp
75+ MarbleMap.cpp
76+ MarbleControlBox.cpp
77+ NavigationWidget.cpp
78+ MapViewWidget.cpp
79+ FileViewWidget.cpp
80+ LegendWidget.cpp
81+ CurrentLocationWidget.cpp
82+ MarbleNavigator.cpp
83+ MarbleLegendBrowser.cpp
84+ MarbleThemeSelectView.cpp
85+ MarbleSearchListView.cpp
86+ MarbleAboutDialog.cpp
87+ MarbleWidgetInputHandler.cpp
88+ MarbleWidgetPopupMenu.cpp
89+ MarblePlacemarkModel.cpp
90+ GeoDataTreeModel.cpp
91+ kdescendantsproxymodel.cpp
92+ MarbleDebug.cpp
93+ TextureTile.cpp
94+ TileCoordsPyramid.cpp
95+ TileLevelRangeWidget.cpp
96+ TileLoader.cpp
97+ QtMarbleConfigDialog.cpp
98+ ClipPainter.cpp
99+ DownloadPolicy.cpp
100+ DownloadQueueSet.cpp
101+ GeoPainter.cpp
102+ GeoPolygon.cpp
103+ HttpDownloadManager.cpp
104+ HttpJob.cpp
105+ NetworkPlugin.cpp
106+ LayerManager.cpp
107+ PluginManager.cpp
108+ MarbleCacheSettingsWidget.cpp
109+ TimeControlWidget.cpp
110+ AbstractFloatItem.cpp
111+ global.cpp
112+ MarbleDirs.cpp
113+ MarbleLocale.cpp
114+ MarblePhysics.cpp
115+ DeferredFlag.cpp
116+ TileCreatorDialog.cpp
117+ MapThemeManager.cpp
118+ ViewportParams.cpp
119+ ViewParams.cpp
120+ Projections/AbstractProjection.cpp
121+ Projections/SphericalProjection.cpp
122+ Projections/EquirectProjection.cpp
123+ Projections/MercatorProjection.cpp
124+ VisiblePlacemark.cpp
125+ PlacemarkPainter.cpp
126+ PlacemarkInfoDialog.cpp
127+ Planet.cpp
128+ Quaternion.cpp
129+ TextureColorizer.cpp
130+ TextureMapperInterface.cpp
131+ ScanlineTextureMapperContext.cpp
132+ SphericalScanlineTextureMapper.cpp
133+ EquirectScanlineTextureMapper.cpp
134+ MercatorScanlineTextureMapper.cpp
135+ TileScalingTextureMapper.cpp
136+ DiscCache.cpp
137+ ServerLayout.cpp
138+ StoragePolicy.cpp
139+ CacheStoragePolicy.cpp
140+ FileStoragePolicy.cpp
141+ FileStorageWatcher.cpp
142+ StackedTile.cpp
143+ TileId.cpp
144+ StackedTileLoader.cpp
145+ TileLoaderHelper.cpp
146+ TileCreator.cpp
147+ TinyWebBrowser.cpp
148+ #jsonparser.cpp
149+ VectorComposer.cpp
150+ VectorMap.cpp
151+ FileLoader.cpp
152+ FileManager.cpp
153+ FileViewModel.cpp
154+ PositionTracking.cpp
155+ DataMigration.cpp
156+
157+ AbstractDataPlugin.cpp
158+ AbstractDataPluginModel.cpp
159+ AbstractDataPluginItem.cpp
160+ AbstractWorkerThread.cpp
161+
162+ PluginInterface.cpp
163+ NetworkPluginInterface.cpp
164+ LayerInterface.cpp
165+ RenderPlugin.cpp
166+ RenderPluginInterface.cpp
167+ PositionProviderPlugin.cpp
168+ PositionProviderPluginInterface.cpp
169+ MarblePluginSettingsWidget.cpp
170+ PluginAboutDialog.cpp
171+ PluginItemDelegate.cpp
172+
173+ SunLocator.cpp
174+ MarbleClock.cpp
175+ SunControlWidget.cpp
176+ MergedLayerDecorator.cpp
177+
178+ MathHelper.cpp
179+
180+ LatLonEdit.cpp
181+
182+ MapThemeSortFilterProxyModel.cpp
183+
184+ routing/AlternativeRoutesModel.cpp
185+ routing/Maneuver.cpp
186+ routing/Route.cpp
187+ routing/RouteAnnotator.cpp
188+ routing/RouteRequest.cpp
189+ routing/RouteSegment.cpp
190+ routing/RoutingModel.cpp
191+ routing/RoutingProfile.cpp
192+ routing/RoutingManager.cpp
193+ routing/RoutingLayer.cpp
194+ routing/RoutingLineEdit.cpp
195+ routing/RoutingInputWidget.cpp
196+ routing/RoutingWidget.cpp
197+ routing/RoutingProfilesWidget.cpp
198+ routing/RoutingProfilesModel.cpp
199+ routing/RoutingProfileSettingsDialog.cpp
200+ routing/instructions/InstructionTransformation.cpp
201+ routing/instructions/RoutingInstruction.cpp
202+ routing/instructions/RoutingPoint.cpp
203+ routing/instructions/RoutingWaypoint.cpp
204+ routing/instructions/WaypointParser.cpp
205+
206+ MarbleRunnerManager.cpp
207+
208+ routing/AdjustNavigation.cpp
209+
210+ RunnerPlugin.cpp
211+ MarbleAbstractRunner.cpp
212+ RunnerTask.cpp
213+
214+ BookmarkManager.cpp
215+ EditBookmarkDialog.cpp
216+ BookmarkManagerDialog.cpp
217+ NewBookmarkFolderDialog.cpp
218+
219+ PrintOptionsWidget.cpp
220+ ExternalEditorDialog.cpp
221+ GoToDialog.cpp
222+
223+ MapWizard.cpp
224+ GeoGraphicsScene.cpp
225+ ElevationModel.cpp
226+
227+ kineticmodel.cpp
228+)
229+
230+set (marblewidget_UI
231+ LatLonBoxWidget.ui
232+ NavigationWidget.ui
233+ LegendWidget.ui
234+ MapViewWidget.ui
235+ CurrentLocationWidget.ui
236+ FileViewWidget.ui
237+ MarbleNavigator.ui
238+ MarbleViewSettingsWidget.ui
239+ MarbleNavigationSettingsWidget.ui
240+ MarbleCacheSettingsWidget.ui
241+ TimeControlWidget.ui
242+ MarbleTimeSettingsWidget.ui
243+ MarblePluginSettingsWidget.ui
244+ TileCreatorDialog.ui
245+ TileLevelRangeWidget.ui
246+ PlacemarkInfoDialog.ui
247+ MarbleAboutDialog.ui
248+ SunControlWidget.ui
249+ LatLonEdit.ui
250+ routing/RoutingWidget.ui
251+ DataMigrationWidget.ui
252+ EditBookmarkDialog.ui
253+ BookmarkManagerDialog.ui
254+ NewBookmarkFolderDialog.ui
255+ PrintOptions.ui
256+ ExternalEditor.ui
257+ GoToDialog.ui
258+ routing/RoutingSettingsWidget.ui
259+ routing/RoutingProfileSettingsDialog.ui
260+ MapWizard.ui
261+)
262+
263+# FIXME: cleaner approach of src/lib/MarbleControlBox.* vs. marble.qrc
264+qt4_add_resources(marblewidget_SRCS libmarble.qrc ../marble.qrc)
265+
266+qt4_wrap_ui(marblewidget_SRCS ${marblewidget_UI})
267+qt4_automoc(${marblewidget_SRCS})
268+
269+
270+# link with release version of Qt libs
271+ADD_LIBRARY(marblewidget SHARED ${marblewidget_SRCS} ${SOURCES_UI_HDRS})
272+TARGET_LINK_LIBRARIES (marblewidget ${QT_QTCORE_LIBRARY} ${QT_QTDBUS_LIBRARY} ${QT_QTGUI_LIBRARY} ${QT_QTXML_LIBRARY} ${QT_QTSVG_LIBRARY} ${QT_QTNETWORK_LIBRARY} ${QT_QTSCRIPT_LIBRARY} ${QT_QTMAIN_LIBRARY} ${QT_QTWEBKIT_LIBRARY} )
273+
274+if (APPLE)
275+ #defined in top level makefile
276+ TARGET_LINK_LIBRARIES(marblewidget ${MAC_EXTRA_LIBS} )
277+endif (APPLE)
278+
279+if (CMAKE_SYSTEM_NAME MATCHES "SunOS")
280+ TARGET_LINK_LIBRARIES(marblewidget m)
281+endif (CMAKE_SYSTEM_NAME MATCHES "SunOS")
282+
283+if(WIN32)
284+ TARGET_LINK_LIBRARIES(marblewidget ws2_32 imm32 winmm)
285+endif(WIN32)
286+
287+
288+set_target_properties(marblewidget PROPERTIES
289+ VERSION ${GENERIC_LIB_VERSION}
290+ SOVERSION ${GENERIC_LIB_SOVERSION}
291+ COMPILE_FLAGS "-DKML_LAZY_IMP")
292+# needed for marble_export.h
293+set_target_properties(marblewidget PROPERTIES
294+ DEFINE_SYMBOL MAKE_MARBLE_LIB
295+)
296+
297+# choose the correct target install library path
298+if(WIN32 AND QTONLY)
299+ install(TARGETS marblewidget RUNTIME DESTINATION ${CMAKE_INSTALL_PREFIX})
300+else(WIN32 AND QTONLY)
301+ if(APPLE AND QTONLY)
302+ install (TARGETS marblewidget LIBRARY DESTINATION
303+ ${CMAKE_INSTALL_PREFIX}/Marble.app/Contents/MacOS/lib)
304+
305+ else(APPLE AND QTONLY)
306+ if(QTONLY)
307+ install(TARGETS marblewidget LIBRARY DESTINATION ${EXEC_INSTALL_PREFIX}/lib${LIB_SUFFIX})
308+ else(QTONLY)
309+ install(TARGETS marblewidget ${INSTALL_TARGETS_DEFAULT_ARGS})
310+ endif(QTONLY)
311+ endif(APPLE AND QTONLY)
312+endif(WIN32 AND QTONLY)
313+
314+########### install files ###############
315+
316+if (APPLE AND QTONLY)
317+ # do nothing because we dont put .h files in the bundle
318+else (APPLE AND QTONLY)
319+ install( FILES
320+ ${graphicsview_HDRS}
321+ BookmarkManager.h
322+ DownloadRegionDialog.h
323+ LatLonBoxWidget.h
324+ MarbleWidget.h
325+ MarbleMap.h
326+ MarbleModel.h
327+ MarbleControlBox.h
328+ NavigationWidget.h
329+ MapViewWidget.h
330+ LegendWidget.h
331+ FileViewWidget.h
332+ CurrentLocationWidget.h
333+ MarbleNavigator.h
334+ AbstractFloatItem.h
335+ MapThemeManager.h
336+ MarbleAboutDialog.h
337+ MarbleWidgetInputHandler.h
338+ TileCoordsPyramid.h
339+ TileLevelRangeWidget.h
340+ TinyWebBrowser.h
341+ QtMarbleConfigDialog.h
342+ global.h
343+ MarbleDirs.h
344+ GeoPainter.h
345+ TileCreatorDialog.h
346+ ViewportParams.h
347+ Projections/AbstractProjection.h
348+ Projections/SphericalProjection.h
349+ Projections/EquirectProjection.h
350+ Projections/MercatorProjection.h
351+ PositionTracking.h
352+ Quaternion.h
353+ SunLocator.h
354+ ClipPainter.h
355+ GeoGraphicsScene.h
356+ geodata/data/GeoDataAbstractView.h
357+ geodata/data/GeoDataAccuracy.h
358+ geodata/data/GeoDataColorStyle.h
359+ geodata/data/GeoDataContainer.h
360+ geodata/data/GeoDataCoordinates.h
361+ geodata/data/GeoDataDocument.h
362+ geodata/data/GeoDataFeature.h
363+ geodata/data/GeoDataFolder.h
364+ geodata/data/GeoDataGeometry.h
365+ geodata/data/GeoDataHotSpot.h
366+ geodata/data/GeoDataIconStyle.h
367+ geodata/data/GeoDataLabelStyle.h
368+ geodata/data/GeoDataLatLonAltBox.h
369+ geodata/data/GeoDataLatLonBox.h
370+ geodata/data/GeoDataLinearRing.h
371+ geodata/data/GeoDataLineString.h
372+ geodata/data/GeoDataLineStyle.h
373+ geodata/data/GeoDataLod.h
374+ geodata/data/GeoDataLookAt.h
375+ geodata/data/GeoDataMultiGeometry.h
376+ geodata/data/GeoDataObject.h
377+ geodata/data/GeoDataPlacemark.h
378+ geodata/data/GeoDataPoint.h
379+ geodata/data/GeoDataPolygon.h
380+ geodata/data/GeoDataPolyStyle.h
381+ geodata/data/GeoDataRegion.h
382+ geodata/data/GeoDataStyle.h
383+ geodata/data/GeoDataStyleMap.h
384+ geodata/data/GeoDataStyleSelector.h
385+ geodata/data/Serializable.h
386+ geodata/geodata_export.h
387+ geodata/parser/GeoDocument.h
388+ routing/RoutingWidget.h
389+ routing/RoutingManager.h
390+ TileCreator.h
391+ PluginInterface.h
392+ RenderPlugin.h
393+ RenderPluginInterface.h
394+ MarbleRunnerManager.h
395+ MarbleAbstractRunner.h
396+ RunnerPlugin.h
397+ LayerInterface.h
398+ PluginAboutDialog.h
399+ marble_export.h
400+ Planet.h
401+
402+ AbstractDataPlugin.h
403+ AbstractDataPluginModel.h
404+ AbstractDataPluginItem.h
405+ AbstractWorkerThread.h
406+
407+ LatLonEdit.h
408+ MapWizard.h
409+ ElevationModel.h
410+
411+ routing/AlternativeRoutesModel.h
412+ routing/Route.h
413+ routing/Maneuver.h
414+ routing/RouteRequest.h
415+ routing/RouteSegment.h
416+ routing/RoutingManager.h
417+ routing/RoutingModel.h
418+ routing/RoutingProfile.h
419+
420+ DESTINATION ${CMAKE_INSTALL_PREFIX}/include/marble
421+)
422+endif (APPLE AND QTONLY)
423
424=== modified file '.pc/applied-patches'
425--- .pc/applied-patches 2012-03-30 20:14:23 +0000
426+++ .pc/applied-patches 2013-03-30 11:11:23 +0000
427@@ -0,0 +1,1 @@
428+add-missing-header.diff
429
430=== modified file 'debian/changelog'
431--- debian/changelog 2012-09-07 16:54:08 +0000
432+++ debian/changelog 2013-03-30 11:11:23 +0000
433@@ -1,3 +1,9 @@
434+marble (4:4.8.5-0ubuntu0.2) precise-proposed; urgency=low
435+
436+ * Install GeoDataTreeModel.h (LP: #1049473).
437+
438+ -- Dmitry Shachnev <mitya57@ubuntu.com> Sat, 30 Mar 2013 14:40:49 +0400
439+
440 marble (4:4.8.5-0ubuntu0.1) precise-proposed; urgency=low
441
442 [ Scott Kitterman ]
443
444=== added directory 'debian/patches'
445=== added file 'debian/patches/add-missing-header.diff'
446--- debian/patches/add-missing-header.diff 1970-01-01 00:00:00 +0000
447+++ debian/patches/add-missing-header.diff 2013-03-30 11:11:23 +0000
448@@ -0,0 +1,14 @@
449+Description: Install GeoDataTreeModel.h
450+Origin: upstream, https://projects.kde.org/projects/kde/kdeedu/marble/repository/revisions/c644c3cbcc
451+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1049473
452+
453+--- a/src/lib/CMakeLists.txt
454++++ b/src/lib/CMakeLists.txt
455+@@ -346,6 +346,7 @@
456+ SunLocator.h
457+ ClipPainter.h
458+ GeoGraphicsScene.h
459++ GeoDataTreeModel.h
460+ geodata/data/GeoDataAbstractView.h
461+ geodata/data/GeoDataAccuracy.h
462+ geodata/data/GeoDataColorStyle.h
463
464=== added file 'debian/patches/series'
465--- debian/patches/series 1970-01-01 00:00:00 +0000
466+++ debian/patches/series 2013-03-30 11:11:23 +0000
467@@ -0,0 +1,1 @@
468+add-missing-header.diff
469
470=== modified file 'src/lib/CMakeLists.txt'
471--- src/lib/CMakeLists.txt 2011-12-24 17:12:32 +0000
472+++ src/lib/CMakeLists.txt 2013-03-30 11:11:23 +0000
473@@ -346,6 +346,7 @@
474 SunLocator.h
475 ClipPainter.h
476 GeoGraphicsScene.h
477+ GeoDataTreeModel.h
478 geodata/data/GeoDataAbstractView.h
479 geodata/data/GeoDataAccuracy.h
480 geodata/data/GeoDataColorStyle.h

Subscribers

People subscribed via source and target branches