Merge lp:~mitya57/kubuntu-packaging/qt3d-fix-ftbfs into lp:~kubuntu-packagers/kubuntu-packaging/qt3d-opensource-src

Proposed by Dmitry Shachnev
Status: Merged
Approved by: Timo Jyrinki
Approved revision: 42
Merged at revision: 42
Proposed branch: lp:~mitya57/kubuntu-packaging/qt3d-fix-ftbfs
Merge into: lp:~kubuntu-packagers/kubuntu-packaging/qt3d-opensource-src
Diff against target: 144 lines (+124/-0)
3 files modified
debian/changelog (+6/-0)
debian/patches/fix_build_on_uncommon_architectures.patch (+117/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~mitya57/kubuntu-packaging/qt3d-fix-ftbfs
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Kubuntu Packagers Pending
Review via email: mp+210963@code.launchpad.net

Commit message

Backport upstream patch to fix build on “uncommon” architectures.

Description of the change

Backport this upstream patch: https://qt.gitorious.org/qt/qt3d/commit/d3338a9f7fcac1

Should fix the build on powerpc, ppc64el and arm64.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-02-28 09:01:02 +0000
3+++ debian/changelog 2014-03-14 05:30:27 +0000
4@@ -1,3 +1,9 @@
5+qt3d-opensource-src (5.0~git20130731-0ubuntu3) UNRELEASED; urgency=medium
6+
7+ * Backport upstream patch to fix build on “uncommon” architectures.
8+
9+ -- Dmitry Shachnev <mitya57@ubuntu.com> Fri, 14 Mar 2014 09:15:26 +0400
10+
11 qt3d-opensource-src (5.0~git20130731-0ubuntu2) trusty; urgency=medium
12
13 [ Timo Jyrinki ]
14
15=== added file 'debian/patches/fix_build_on_uncommon_architectures.patch'
16--- debian/patches/fix_build_on_uncommon_architectures.patch 1970-01-01 00:00:00 +0000
17+++ debian/patches/fix_build_on_uncommon_architectures.patch 2014-03-14 05:30:27 +0000
18@@ -0,0 +1,117 @@
19+Description: Fix assimp build on uncommon architectures
20+Origin: upstream, https://qt.gitorious.org/qt/qt3d/commit/d3338a9f7fcac1
21+Last-Update: 2014-03-14
22+
23+--- a/3rdparty/assimp/code/Importer.cpp
24++++ b/3rdparty/assimp/code/Importer.cpp
25+@@ -897,27 +897,35 @@ void WriteLogOpening(const std::string& file)
26+ << aiGetVersionMinor()
27+ << "."
28+ << aiGetVersionRevision()
29++ << " "
30+
31+-#if defined(ASSIMP_BUILD_X86_32BIT_ARCHITECTURE)
32++#if defined(ASSIMP_BUILD_ARCHITECTURE)
33++ << ASSIMP_BUILD_ARCHITECTURE
34++#elif defined(_M_IX86) || defined(__x86_32__) || defined(__i386__)
35+ << " x86"
36+-#elif defined(ASSIMP_BUILD_X86_64BIT_ARCHITECTURE)
37++#elif defined(_M_X64) || defined(__x86_64__)
38+ << " amd64"
39+-#elif defined(ASSIMP_BUILD_IA_64BIT_ARCHITECTURE)
40++#elif defined(_M_IA64) || defined(__ia64__)
41+ << " itanium"
42+-#elif defined(ASSIMP_BUILD_PPC_32BIT_ARCHITECTURE)
43++#elif defined(__ppc__) || defined(__powerpc__)
44+ << " ppc32"
45+-#elif defined(ASSIMP_BUILD_ARM_32BIT_ARCHITECTURE)
46+- << " arm32"
47++#elif defined(__powerpc64__)
48++ << " ppc64"
49++#elif defined(__arm__)
50++ << " arm"
51+ #else
52+-# error unknown architecture
53++ << " unknown architecture"
54+ #endif
55+
56+-#if defined(_MSC_VER)
57++ << " "
58++#if defined(ASSIMP_BUILD_COMPILER)
59++ << ASSIMP_BUILD_COMPILER
60++#elif defined(_MSC_VER)
61+ << " msvc"
62+ #elif defined(__GNUC__)
63+ << " gcc"
64+ #else
65+-# warning unknown compiler
66++# << " unknown compiler"
67+ #endif
68+
69+ #ifndef NDEBUG
70+--- a/3rdparty/assimp/include/aiDefines.h
71++++ b/3rdparty/assimp/include/aiDefines.h
72+@@ -219,41 +219,6 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
73+ #endif
74+
75+ //////////////////////////////////////////////////////////////////////////
76+- /* ASSIMP_BUILD_XXXX_NNBIT_ARCHITECTURE */
77+- //////////////////////////////////////////////////////////////////////////
78+-#if defined(_MSC_VER)
79+- // See http://msdn.microsoft.com/en-us/library/b0084kay.
80+-# if defined(_M_IX86)
81+-# define ASSIMP_BUILD_X86_32BIT_ARCHITECTURE
82+-# elif defined(_M_X64)
83+-# define ASSIMP_BUILD_X86_64BIT_ARCHITECTURE
84+-# elif defined(_M_IA64)
85+-# define ASSIMP_BUILD_IA_64BIT_ARCHITECTURE
86+-# else
87+-# error unknown architecture
88+-# endif
89+-#elif defined(__GNUC__)
90+- // See http://gcc.gnu.org/onlinedocs/cpp/Predefined-Macros.html.
91+-# if defined(__x86_32__) || defined(__i386__)
92+-# define ASSIMP_BUILD_X86_32BIT_ARCHITECTURE
93+-# elif defined(__x86_64__)
94+-# define ASSIMP_BUILD_X86_64BIT_ARCHITECTURE
95+-# elif defined(__ppc__)
96+-# define ASSIMP_BUILD_PPC_32BIT_ARCHITECTURE
97+-# elif defined(__arm__)
98+-# define ASSIMP_BUILD_ARM_32BIT_ARCHITECTURE
99+-# else
100+-# error unknown architecture
101+-# endif
102+-#elif defined (__GCCE__)
103+-#define ASSIMP_BUILD_ARM_32BIT_ARCHITECTURE
104+-#elif defined (__arm__)
105+-#define ASSIMP_BUILD_ARM_32BIT_ARCHITECTURE
106+-#else //assume
107+-# error unknown compiler
108+-#endif
109+-
110+- //////////////////////////////////////////////////////////////////////////
111+ /* Useful constants */
112+ //////////////////////////////////////////////////////////////////////////
113+
114+@@ -271,8 +236,19 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
115+ #define AI_DEG_TO_RAD(x) (x*0.0174532925f)
116+ #define AI_RAD_TO_DEG(x) (x*57.2957795f)
117+
118+-/* Support for big-endian builds on Mac OS X. */
119+-#if defined(__APPLE__) && defined(__BIG_ENDIAN__)
120++/* Support for big-endian builds */
121++#if defined(__BYTE_ORDER__)
122++# if (__BYTE_ORDER__ == __ORDER_BIG_ENDIAN__)
123++# if !defined(__BIG_ENDIAN__)
124++# define __BIG_ENDIAN__
125++# endif
126++# else /* little endian */
127++# if defined(__BIG_ENDIAN__)
128++# undef(__BIG_ENDIAN__)
129++# endif
130++# endif
131++#endif
132++#if defined(__BIG_ENDIAN__)
133+ #define AI_BUILD_BIG_ENDIAN
134+ #endif
135+
136
137=== modified file 'debian/patches/series'
138--- debian/patches/series 2014-02-06 17:19:45 +0000
139+++ debian/patches/series 2014-03-14 05:30:27 +0000
140@@ -1,3 +1,4 @@
141 link_against_system_zlib.patch
142 workaround_zlib_linking_issue.patch
143 skip_failing_tests.patch
144+fix_build_on_uncommon_architectures.patch

Subscribers

People subscribed via source and target branches