lp:~mitya57/jenkins-launchpad-plugin/no-empty-approved-by

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~private-ps-quality-team/jenkins-launchpad-plugin/trunk at revision 70

Francis Ginther: Approve on 2013-01-28

PS Jenkins bot: Pending (continuous-integration) requested 2013-01-28

Diff: 57 lines (+18/-6)

2 files modified

autoland.py (+8/-4)
tests/test_autoland.py (+10/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

72. By Dmitry Shachnev on 2013-01-28

Fix an error from previous commit

71. By Dmitry Shachnev on 2013-01-25

- Try to fall back to branch approver first
- Add a test case (from Francis Ginther)

70. By Dmitry Shachnev on 2013-01-12

autoland.py: Do not add "Approved by" string if it is empty

69. By Martin Mrazik on 2012-12-07

This is changing the locking mechanism for accessing launchpadlib (launchpadlib is not process safe) from FileLock to custom SocketLock. The main difference is that SocketLock binds a SOCK_DGRAM socket which is cleaned up by OS when the process dies. The current file locking scheme was leaving stale locks which were never cleaned up.
The tests are not meant to be unit test but they are testing real processes instead.
.

Approved by Michael Zanetti, PS Jenkins bot.

68. By Francis Ginther on 2012-12-06

Clean up pep8 issues introduced by dev-strip-inputs merge proposal.

Approved by Martin Mrazik, PS Jenkins bot.

67. By Francis Ginther on 2012-12-06

Strip double quotes from environment variables which jenkins may add.

Approved by Martin Mrazik, PS Jenkins bot.

66. By Martin Mrazik on 2012-11-30

This is fixing the situation when you have a development branch you use for creating MP and doing something like this:
1. create a MP and wait until its merged
2. do some more changes to your branch
3. create another MP.

Approved by Sergio Schvezov, PS Jenkins bot.

65. By Martin Mrazik on 2012-11-27

adding UPSTREAM_VERSION param to format string while PACKAGE_VERSION is now the real package version.

Approved by Sergio Schvezov, Francis Ginther, PS Jenkins bot.

64. By Martin Mrazik on 2012-11-22

This adds link for coverity artifacts if there are some.

Approved by PS Jenkins bot, Allan LeSage.

63. By Martin Mrazik on 2012-11-20

Adding a direct link to trigger a (CI only) rebuild.
I don't want to add the link for autolanding as it is a bit more tricky there (you need to set the state to approve anyway and that will trigger the building; if you would trigger manually _and_ change the state to Approved there is a potential for race condition). Fixes: https://bugs.launchpad.net/bugs/1078350.

Approved by Michael Zanetti.