Merge lp:~mithunit/pogo/open-containing-folder into lp:~jendrikseipp/pogo/trunk

[Jendrik Seipp]

open-containing-folder

[Jendrik Seipp (jendrikseipp)]

Thanks for implementing the feature. It works very nicely!

Do you know if there is any way to highlight the selected folder or track in nautilus?

For the next time it would be better not to remove spaces from empty lines. This way the diff looks cleaner and is easier to understand.

But very nicely done, you have perfectly understood how to use the existing code.

review: Needs Information

[Tim㋡ (tim.h.s)]

...............................................................................................................

  Hi Mithun,

  Thank you very much this nice feature works really good :)

cheers
Tim
<email address hidden>

--
Wissenschaften entfernen sich im Ganzen immer vom Leben und
kehren nur durch einen Umweg wieder dahin zurück.
  -- Goethe, Maximen und Reflektionen, Nr. 825

[Mithun J. Shitole (mithunit)]

>
> Do you know if there is any way to highlight the selected folder or track in
> nautilus?
I have checked the man pages of xdg-open , unfortunately there isn't a way to do it using xdg-open. We may need to find some other way to do it, but which will make it specific to nautilus

>
> For the next time it would be better not to remove spaces from empty lines.
> This way the diff looks cleaner and is easier to understand.

Really sorry for that, although I haven't removed them manually, maybe my gedit settings done so automatically. Do you want me to commit it again without removing spaces?

> But very nicely done, you have perfectly understood how to use the existing
> code.

Its good to see that my code is usable :)

[Jendrik Seipp (jendrikseipp)]

>> Do you know if there is any way to highlight the selected folder or track in
>> nautilus?
> I have checked the man pages of xdg-open , unfortunately there isn't a way to do it using xdg-open. We may need to find some other way to do it, but which will make it specific to nautilus
Could you look into that? This would be a great feature, although I'm
not sure if it can be done.
> Really sorry for that, although I haven't removed them manually, maybe my gedit settings done so automatically. Do you want me to commit it again without removing spaces?
That would probably be good.

[Mithun J. Shitole (mithunit)]

On Wednesday 27 October 2010 03:52 PM, Jendrik Seipp wrote:
>
>>> Do you know if there is any way to highlight the selected folder or track in
>>> nautilus?
>>>
>> I have checked the man pages of xdg-open , unfortunately there isn't a way to do it using xdg-open. We may need to find some other way to do it, but which will make it specific to nautilus
>>
> Could you look into that? This would be a great feature, although I'm
> not sure if it can be done.
>
I tried to find out a solution, unfortunately I haven't find anything :( .

>> Really sorry for that, although I haven't removed them manually, maybe my gedit settings done so automatically. Do you want me to commit it again without removing spaces?
>>
> That would probably be good.
>
 I will do it asap.

Regards,
Mithun

[Jendrik Seipp (jendrikseipp)]

OK, I guess then it's just impossible to highlight the files. BTW, what do you guys think? Would it be best to have the "Open containing folder" feature:

- only for the filebrowser?
- only for the playlist?
- for both?

[lp:~mithunit/pogo/open-containing-folder]

298. By Mithun Shitole <mithun@mithun-laptop> on 2010-11-05

Restored whitespaces

[Jendrik Seipp (jendrikseipp)]

Hi, I just merged your feature. Good work!

review: Approve

=== modified file 'src/modules/FileExplorer.py' (properties changed: -x to +x)
--- src/modules/FileExplorer.py	2010-11-05 02:31:23 +0000
+++ src/modules/FileExplorer.py	2010-11-05 05:54:45 +0000
@@ -17,9 +17,18 @@
 # along with this program; if not, write to the Free Software
 # Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
 
+<<<<<<< TREE
 import os
 import urllib2
 import itertools
+=======
+import re
+
+import gtk, media, modules, os, tools,subprocess
+
+from tools   import consts, prefs, icons
+from media   import playlist
+>>>>>>> MERGE-SOURCE
 from gettext import gettext as _
 from os.path import isdir, isfile
 
@@ -322,7 +331,14 @@
             if self.tree.row_expanded(child):
                 idle_add(self.refresh, child)
 
-
+    def showFolder(self, folderPath):
+        """ Show containing folder in default file browser """
+        if os.name == 'mac':
+            subprocess.call(('open', folderPath))
+        elif os.name == 'nt':
+            subprocess.call(('start', folderPath))
+        elif os.name == 'posix':
+            subprocess.call(('xdg-open', folderPath))
     # --== GTK handlers ==--
 
 
@@ -385,6 +401,16 @@
                 popup.append(dir)
                                         
 
+        popup.append(gtk.SeparatorMenuItem())
+
+        #open containing folder
+        showFolder = gtk.ImageMenuItem(gtk.STOCK_OPEN)
+        showFolder.set_label(_('Open containing folder'))
+        folderPaths = [row[ROW_FULLPATH] for row in self.tree.getSelectedRows()]
+        folderPath = os.path.dirname(folderPaths[0])
+        showFolder.connect('activate', lambda widget: self.showFolder(folderPath))
+        popup.append(showFolder)
+
         popup.show_all()
         popup.popup(None, None, None, button, time)