Kali

Merge lp:~mithrandi/kali/channel-modes into lp:kali

  1. channel-modes
  2. Merge into trunk
Proposed by Tristan Seligmann
Status: Merged
Merged at revision: not available
Proposed branch: lp:~mithrandi/kali/channel-modes
Merge into: lp:kali
To merge this branch: bzr merge lp:~mithrandi/kali/channel-modes
Reviewer Review Type Date Requested Status
Jeremy Thurgood Approve
Review via email: mp+3108@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Tristan Seligmann (mithrandi) wrote :

Emits different events for changes of different kinds of modes, and track these properly in the Channel object in the controller.

Revision history for this message
Jeremy Thurgood (jerith) wrote :

I like the mode events refactoring -- it lets us handle a lot more server-specific stuff in the protocol rather than the services.

I think we want at least some kind of configuration around the channelParamModes, etc. since those can be added and removed with modules in InspIRCd, but that can wait until we actually need it.

[Note: I'm on my parents' machine, so I haven't actually tested the modified code.]

review: Approve

Subscribers

People subscribed via source and target branches