Merge ~mitchdz/ubuntu/+source/multipath-tools:mitch/manually_restart_multipathd_on_upgrade_to_systemd_only_package-jammy into ubuntu/+source/multipath-tools:ubuntu/jammy-devel

[Mitchell Dzurick]

PPA - https://launchpad.net/~mitchdz/+archive/ubuntu/multipath-tools-2035098

[Andreas Hasenack (ahasenack)]

I added review comments to the lunar version[1] of this MP, and will continue the review there.

1. https://code.launchpad.net/~mitchdz/ubuntu/+source/multipath-tools/+git/multipath-tools/+merge/451738

[Mitchell Dzurick (mitchdz)]

Thanks Andreas! Let's just have the conversation in the Lunar MP, I will apply whatever changes to this MP once we are satisfied.

[Andreas Hasenack (ahasenack)]

Same text suggestions as in the lunar MP.

[Andreas Hasenack (ahasenack)]

+1 and sponsored

review: Approve

diff --git a/debian/changelog b/debian/changelog
index 2330fce..92cc3fb 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+multipath-tools (0.8.8-1ubuntu1.22.04.3) jammy; urgency=medium
+
+  * debian/multipath-tools.postinst: restart multipathd when upgrading from lt
+    0.8.8-1ubuntu1.22.04.3 (LP: #2035098)
+
+ -- Mitchell Dzurick <[e-mail]>  Wed, 20 Sep 2023 08:05:06 -0700
+
 multipath-tools (0.8.8-1ubuntu1.22.04.2) jammy; urgency=medium
 
   [ Sergio Durigan Junior ]
diff --git a/debian/multipath-tools.postinst b/debian/multipath-tools.postinst
new file mode 100644
index 0000000..f93c1dc
--- /dev/null
+++ b/debian/multipath-tools.postinst
@@ -0,0 +1,30 @@
+#!/bin/sh
+# postinst script for multipath-tools
+#
+# see: dh_installdeb(1)
+
+set -e
+
+FIXED=0.8.8-1ubuntu1.22.04.3
+# The previous multipath-tools.prerm maintainer script did not stop the
+# multipathd.service unit, therefore it needs to be stopped here for this
+# specific upgrade case.
+# "systemctl daemon-reload" is specifically not being called before
+#  deb-systemd-invoke because:
+#   a) it will be called later in the script, before multipathd.service is
+#      started, so let's not call it twice
+#   b) it has system-wide effects, like running all systemd generators again
+#   c) we don't really need the new multipathd.service unit file to stop the old
+#      running daemon. In fact, one could argue it's more correct to use the old
+#      unit file to stop the old daemon.
+# This approach will generate a one-time warning that can be ignored.
+if dpkg --compare-versions "$2" lt-nl "$FIXED"; then
+    echo -n "The warning about having to reload systemd units can be safely" >&2
+    echo " ignored. Please see LP: #2035098 for details." >&2
+
+    deb-systemd-invoke stop 'multipathd.service' >/dev/null || true
+fi
+
+#DEBHELPER#
+
+exit 0