Merge ~mitchdz/ubuntu/+source/multipath-tools:mitch/manually_restart_multipathd_on_upgrade_to_systemd_only_package-lunar into ubuntu/+source/multipath-tools:ubuntu/jammy-devel

Proposed by Mitchell Dzurick
Status: Superseded
Proposed branch: ~mitchdz/ubuntu/+source/multipath-tools:mitch/manually_restart_multipathd_on_upgrade_to_systemd_only_package-lunar
Merge into: ubuntu/+source/multipath-tools:ubuntu/jammy-devel
Diff against target: 78 lines (+44/-0) (has conflicts)
3 files modified
debian/changelog (+18/-0)
debian/multipath-tools.maintscript (+4/-0)
debian/multipath-tools.postinst (+22/-0)
Conflict in debian/changelog
Conflict in debian/multipath-tools.maintscript
Reviewer Review Type Date Requested Status
git-ubuntu import Pending
Review via email: mp+451737@code.launchpad.net

This proposal has been superseded by a proposal from 2023-09-20.

To post a comment you must log in.

Unmerged commits

bbb6053... by Mitchell Dzurick

changelog

39377b4... by Mitchell Dzurick

debian/multipath-tools.postinst: restart when uprading to 0.8.8-1ubuntu2.2

When we removed the init scripts, invoke-rc.d handled stopping the multipathd
service in prerm, so we explicitly handle service/socket restarting on upgrade.

252a5bd... by Mitchell Dzurick

changelog

99af2f1... by Mitchell Dzurick

Do not install init scripts (LP: #2000186)

 - d/multipath-tools.maintscript: remove /etc/init.d/multipath-tools
 - d/rules: do not call dh_installinit

 This change is necessary mostly just to remove dh_installinit as
 there has been cases where dpkg fails to upgrade
 multipath-tools because dh_installinit calls invoke-rc.d which
 fails. We could fix this by adding --no-start to dh_installinit
 but might as well just remove the init scripts all together.

384860d... by Mitchell Dzurick

* d/p/0018-libmpathpersist-fix-command-keyword-ordering.patch:
    Fix mpathpersist command keyword ordering. (LP: #2026881)

51b0a77... by Marc Deslauriers

0.8.8-1ubuntu2 (patches unapplied)

Imported using git-ubuntu import.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 2330fce..d99ede9 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,4 @@
6+<<<<<<< debian/changelog
7 multipath-tools (0.8.8-1ubuntu1.22.04.2) jammy; urgency=medium
8
9 [ Sergio Durigan Junior ]
10@@ -5,13 +6,30 @@ multipath-tools (0.8.8-1ubuntu1.22.04.2) jammy; urgency=medium
11 Fix mpathpersist command keyword ordering. (LP: #2026881)
12
13 [ Mitchell Dzurick ]
14+=======
15+multipath-tools (0.8.8-1ubuntu2.2) lunar; urgency=medium
16+
17+ * debian/multipath-tools.postinst: restart multipathd when upgrading to
18+ 0.8.8-1ubuntu2.2 (LP: #2035098)
19+
20+ -- Mitchell Dzurick <mitchell.dzurick@canonical.com> Wed, 20 Sep 2023 05:18:54 -0700
21+
22+multipath-tools (0.8.8-1ubuntu2.1) lunar; urgency=medium
23+
24+ * d/p/0018-libmpathpersist-fix-command-keyword-ordering.patch:
25+ Fix mpathpersist command keyword ordering. (LP: #2026881)
26+>>>>>>> debian/changelog
27 * Do not install init scripts (LP: #2000186)
28 - d/multipath-tools.maintscript: remove /etc/init.d/multipath-tools
29 - d/rules: do not call dh_installinit
30
31 -- Mitchell Dzurick <mitchell.dzurick@canonical.com> Thu, 13 Jul 2023 11:50:32 -0700
32
33+<<<<<<< debian/changelog
34 multipath-tools (0.8.8-1ubuntu1.22.04.1) jammy-security; urgency=medium
35+=======
36+multipath-tools (0.8.8-1ubuntu2) lunar; urgency=medium
37+>>>>>>> debian/changelog
38
39 * SECURITY UPDATE: symlink attack
40 - debian/patches/CVE-2022-41973.patch: use /run instead of /dev/shm in
41diff --git a/debian/multipath-tools.maintscript b/debian/multipath-tools.maintscript
42index c1b8897..4f532bd 100644
43--- a/debian/multipath-tools.maintscript
44+++ b/debian/multipath-tools.maintscript
45@@ -1 +1,5 @@
46+<<<<<<< debian/multipath-tools.maintscript
47 rm_conffile /etc/init.d/multipath-tools 0.8.8-1ubuntu1.22.04.2~ multipath-tools
48+=======
49+rm_conffile /etc/init.d/multipath-tools 0.8.8-1ubuntu2.1~ multipath-tools
50+>>>>>>> debian/multipath-tools.maintscript
51diff --git a/debian/multipath-tools.postinst b/debian/multipath-tools.postinst
52new file mode 100644
53index 0000000..f376e9a
54--- /dev/null
55+++ b/debian/multipath-tools.postinst
56@@ -0,0 +1,22 @@
57+#!/bin/sh
58+# postinst script for multipath-tools
59+#
60+# see: dh_installdeb(1)
61+
62+set -e
63+
64+#DEBHELPER#
65+
66+FIXED=0.8.8-1ubuntu2.2
67+# When we removed the initscripts, invoke-rc.d was used to stop the service
68+# in the prerm. So this is just to handle the transition from the package that
69+# has init scripts, to the one with just systemd scripts. Going forward, the
70+# service will restart on future upgrades fine.
71+# https://bugs.launchpad.net/ubuntu/+source/multipath-tools/+bug/2035098
72+if dpkg --compare-versions "$2" lt-nl "$FIXED"; then
73+ systemctl --system daemon-reload >/dev/null || true
74+ deb-systemd-invoke stop 'multipathd.service' 'multipathd.socket' >/dev/null || true
75+ deb-systemd-invoke start 'multipathd.socket' 'multipathd.service' >/dev/null || true
76+fi
77+
78+exit 0

Subscribers

People subscribed via source and target branches