Merge ~mitchdz/ubuntu/+source/apache2:mitch/mantic-add-ubuntu-logo into ubuntu/+source/apache2:ubuntu/mantic-devel

Proposed by Mitchell Dzurick
Status: Work in progress
Proposed branch: ~mitchdz/ubuntu/+source/apache2:mitch/mantic-add-ubuntu-logo
Merge into: ubuntu/+source/apache2:ubuntu/mantic-devel
Diff against target: 18 lines (+6/-0)
1 file modified
debian/changelog (+6/-0)
Reviewer Review Type Date Requested Status
Andreas Hasenack Needs Fixing
Sergio Durigan Junior (community) Approve
Canonical Server Reporter Pending
Review via email: mp+455517@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks, Mitchell.

As we've discussed, this LGTM. However, because it's a low priority bug, I will stage the SRU.

Uploaded:

$ dput ssh-ubuntu apache2_2.4.57-2ubuntu2.23.10.1_source.changes
D: Setting host argument.
Checking signature on .changes
gpg: /home/sergio/work/apache2/apache2_2.4.57-2ubuntu2.23.10.1_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/apache2/apache2_2.4.57-2ubuntu2.23.10.1.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ssh-ubuntu (via sftp to upload.ubuntu.com):
  Uploading apache2_2.4.57-2ubuntu2.23.10.1.dsc: done.
  Uploading apache2_2.4.57-2ubuntu2.23.10.1.debian.tar.xz: done.
  Uploading apache2_2.4.57-2ubuntu2.23.10.1_source.buildinfo: done.
  Uploading apache2_2.4.57-2ubuntu2.23.10.1_source.changes: done.
Successfully uploaded packages.

review: Approve
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

This upload was rejected[1] on 2023-11-23

Rejected on 2023-11-23 by Andreas Hasenack
You have to rebase on top of the latest update, which is currently 2.4.57-2ubuntu2.1

Marking this MP as "needs fixing" due to the need to rebase.

1. https://launchpad.net/ubuntu/mantic/+queue?queue_state=4&queue_text=apache2

review: Needs Fixing
Revision history for this message
Mitchell Dzurick (mitchdz) wrote :

Whoops this slipped past me while I was on break. Thanks for the update Andreas, I'll rebase it soon.

Revision history for this message
Mitchell Dzurick (mitchdz) wrote :

This MP is no longer valid. Keeping it for posterity. The new active MP is https://code.launchpad.net/~mitchdz/ubuntu/+source/apache2/+git/apache2/+merge/458256

Unmerged commits

9acdebe... by Mitchell Dzurick

changelog

dceebee... by Mitchell Dzurick

d/icons/ubuntu-logo.png: add Ubuntu image

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 118f242..279ef0c 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+apache2 (2.4.57-2ubuntu2.23.10.1) mantic; urgency=medium
7+
8+ * d/icons/ubuntu-logo.png: add Ubuntu image for welcome page (LP: #1947459).
9+
10+ -- Mitchell Dzurick <mitchell.dzurick@canonical.com> Mon, 13 Nov 2023 07:43:48 -0700
11+
12 apache2 (2.4.57-2ubuntu2) mantic; urgency=medium
13
14 * d/control: Upgrade lua build dependency to 5.4
15diff --git a/debian/icons/ubuntu-logo.png b/debian/icons/ubuntu-logo.png
16new file mode 100644
17index 0000000..eee686c
18Binary files /dev/null and b/debian/icons/ubuntu-logo.png differ

Subscribers

People subscribed via source and target branches