Merge ~mitchdz/ppa-dev-tools:mitch/lp2051235-add-credentials-to-suggestion into ppa-dev-tools:main

Proposed by Mitchell Dzurick
Status: Merged
Merge reported by: Bryce Harrington
Merged at revision: 57fc0795bac17ae004dd42a69491be4bb4edc563
Proposed branch: ~mitchdz/ppa-dev-tools:mitch/lp2051235-add-credentials-to-suggestion
Merge into: ppa-dev-tools:main
Diff against target: 26 lines (+6/-2)
1 file modified
scripts/ppa (+6/-2)
Reviewer Review Type Date Requested Status
Bryce Harrington Approve
Canonical Server Reporter Pending
Review via email: mp+463056@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks for the fix Mitchell!

LGTM, I've landed and pushed.

To git+ssh://git.launchpad.net/ppa-dev-tools
   170f4c8..3917dcf main -> main

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/scripts/ppa b/scripts/ppa
2index 2d2937e..8484979 100755
3--- a/scripts/ppa
4+++ b/scripts/ppa
5@@ -435,7 +435,7 @@ def create_arg_parser() -> argparse.ArgumentParser:
6 def create_lp(app_name: str, args: argparse.Namespace) -> Lp:
7 """Instantiate the Lp Launchpad Interface object.
8
9- Use credentials from the file file specified by --credentials , if
10+ Use credentials from the file specified by --credentials , if
11 provided. If not, next try to use contents from the LP_CREDENTIALS
12 environment variable. Last, leave creds undefined, and Lp will
13 handle website login and credentials caching automatically.
14@@ -597,7 +597,11 @@ def command_create(lp: Lp, config: dict[str, str]) -> int:
15 print("You can upload packages to this PPA using:\n")
16 print(f" dput {the_ppa.address} <source.changes>\n")
17 print("Wait for the uploads to build and publish using:\n")
18- print(f" ppa wait {the_ppa.address}\n")
19+ credentials_file=config.get('credentials_filename')
20+ if credentials_file:
21+ print(f" ppa --credentials {credentials_file} wait {the_ppa.address}\n")
22+ else:
23+ print(f" ppa wait {the_ppa.address}\n")
24 print("To add the repository and to your system:\n")
25 print(f" sudo add-apt-repository -yus {the_ppa.address}")
26 print(" sudo apt-get install <package(s)>")

Subscribers

People subscribed via source and target branches