Code review comment for ~mitchburton/ubuntu/+source/landscape-client:plucky-fix-build

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

autopkgtests are still failing[1]. Multiple tests show this error pattern with the proxy variables:

626s landscape.client.tests.test_configuration.ConfigurationFunctionsTest.test_silent_setup
626s ===============================================================================
626s [FAIL]
626s Traceback (most recent call last):
626s File "/usr/lib/python3.13/unittest/mock.py", line 1426, in patched
626s return func(*newargs, **newkeywargs)
626s File "/tmp/autopkgtest.62rtX1/build.DIQ/src/landscape/client/tests/test_configuration.py", line 785, in test_silent_setup_no_register
626s self.assertConfigEqual(
626s File "/tmp/autopkgtest.62rtX1/build.DIQ/src/landscape/lib/testing.py", line 192, in assertConfigEqual
626s self.assertEqual(
626s File "/usr/lib/python3/dist-packages/twisted/trial/_synctest.py", line 444, in assertEqual
626s super().assertEqual(first, second, msg)
626s File "/usr/lib/python3.13/unittest/case.py", line 907, in assertEqual
626s assertion_func(first, second, msg=msg)
626s File "/usr/lib/python3.13/unittest/case.py", line 1206, in assertDictEqual
626s self.fail(self._formatMessage(msg, standardMsg))
626s twisted.trial.unittest.FailTest: {'url': 'https://landscape.canonical.com/me[138 chars]128'} != {'data_path': '/tmp/tmpsrhj5v8p/client', 'u[49 chars]tem'}
626s {'data_path': '/tmp/tmpsrhj5v8p/client',
626s - 'http_proxy': 'http://squid.internal:3128',
626s - 'https_proxy': 'http://squid.internal:3128',
626s 'url': 'https://landscape.canonical.com/message-system'}

1. https://autopkgtest.ubuntu.com/results/autopkgtest-plucky-mitchburton-landscape-client-ppa/plucky/amd64/l/landscape-client/20250407_093831_f2105@/log.gz

review: Needs Fixing

« Back to merge proposal