Merge ~mitchburton/lpci:main into lpci:main

Proposed by Mitch Burton
Status: Needs review
Proposed branch: ~mitchburton/lpci:main
Merge into: lpci:main
Diff against target: 12 lines (+1/-0)
1 file modified
lpci/config.py (+1/-0)
Reviewer Review Type Date Requested Status
Launchpad code reviewers Pending
Review via email: mp+465112@code.launchpad.net

Commit message

add noble to PackageSuite enum

Description of the change

Without this there's a pretty clear Pydantic ValidationError error:

$ lpci run-one test-noble 0
lpci internal error: ValidationError(model='Config', errors=[{'loc': ('jobs', 'test-noble', 0, 'package-repositories', 0, 'suites', 0), 'msg': "value is not a valid enumeration member; permitted: 'bionic', 'focal', 'jammy'", 'type': 'type_error.enum', 'ctx': {'enum_values': [<PackageSuite.bionic: 'bionic'>, <PackageSuite.focal: 'focal'>, <PackageSuite.jammy: 'jammy'>]}}])

To post a comment you must log in.

Unmerged commits

3076dcf... by Mitch Burton

add noble to PackageSuite enum

Succeeded
[SUCCEEDED] test:0 (build)
[SUCCEEDED] build:0 (build)
12 of 2 results

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lpci/config.py b/lpci/config.py
2index 4af17e5..a9374a9 100644
3--- a/lpci/config.py
4+++ b/lpci/config.py
5@@ -124,6 +124,7 @@ class PackageSuite(str, Enum):
6 bionic = "bionic" # 18.04
7 focal = "focal" # 20.04
8 jammy = "jammy" # 22.04
9+ noble = "noble" # 24.04
10
11
12 class PPAShortFormURL(pydantic.ConstrainedStr):

Subscribers

People subscribed via source and target branches