Merge ~mirespace/ubuntu/+source/telegraf:fix-canada-eastern-test-ftbfs-noble into ubuntu/+source/telegraf:ubuntu/noble-devel

Proposed by Miriam España Acebal
Status: Rejected
Rejected by: Andreas Hasenack
Proposed branch: ~mirespace/ubuntu/+source/telegraf:fix-canada-eastern-test-ftbfs-noble
Merge into: ubuntu/+source/telegraf:ubuntu/noble-devel
Diff against target: 29 lines (+10/-0)
2 files modified
debian/changelog (+9/-0)
debian/control (+1/-0)
Reviewer Review Type Date Requested Status
Simon Quigley (community) sponsorship Approve
Miriam España Acebal (community) Approve
Daniel Draper Pending
Canonical Server Reporter Pending
Review via email: mp+464527@code.launchpad.net

Description of the change

Hi team,

ppa for this is

https://launchpad.net/~mirespace/+archive/ubuntu/fixing-general-noble-packages/+packages
ppa:mirespace/fixing-general-noble-packages

I added tzdata-legacy as dependency, but not sure if it can conflicts with the normal behaviour of telegraf. I saw some fixes in tzdata for redirect old/incorrect timezones, so maybe this PR is not the right approach, but checking if it overcomes the FTBFS anyway.

To post a comment you must log in.
Revision history for this message
Miriam España Acebal (mirespace) wrote :
Revision history for this message
Miriam España Acebal (mirespace) :
Revision history for this message
Miriam España Acebal (mirespace) wrote :

Spoken with Sergio on MM that if the package was building successfully, I could upload it... so, auto approving and upload.

review: Approve
Revision history for this message
Simon Quigley (tsimonq2) :
review: Approve (sponsorship)
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

What happened to the 1.22.3+ds1-0ubuntu3 upload? I see that 0ubuntu2 was removed from noble[1], and in fact telegraf is not even in oracular (just jammy and mantic at the moment).

1. https://bugs.launchpad.net/ubuntu/+source/telegraf/+bug/2062013

Revision history for this message
Miriam España Acebal (mirespace) wrote :

Hi Andreas,

the upload was not done because of the imminent removal (at that time). I would make this PR Rejected.

Revision history for this message
Miriam España Acebal (mirespace) wrote :

In fact, Could you please mark it as "Rejected" Andreas?

I just learnt you and Robie have the superpowers to do so.

Thanks

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Rejecting as requested

Unmerged commits

be6e655... by Miriam España Acebal

changelog 1.22.3+ds1-0ubuntu3

b6f12ac... by Miriam España Acebal

  * d/control: Add tzdata-legacy to allow retrieve Canada/Eastern
    timezone correctly which was breaking test
    grok.TestTimezoneAmericasCompileFileAndParse
    (LP: #2061991).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index d1bfe51..53b8414 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,12 @@
6+telegraf (1.22.3+ds1-0ubuntu3) noble; urgency=medium
7+
8+ * d/control: Add tzdata-legacy to allow retrieve Canada/Eastern
9+ timezone correctly which was breaking test
10+ grok.TestTimezoneAmericasCompileFileAndParse
11+ (LP: #2061991).
12+
13+ -- Miriam España Acebal <miriam.espana@canonical.com> Wed, 17 Apr 2024 13:14:18 +0200
14+
15 telegraf (1.22.3+ds1-0ubuntu2) lunar; urgency=medium
16
17 * d/rules: Don't run dh_dwz.
18diff --git a/debian/control b/debian/control
19index 8f328d4..6a75d45 100644
20--- a/debian/control
21+++ b/debian/control
22@@ -7,6 +7,7 @@ Build-Depends: debhelper-compat (= 13),
23 python3-docutils,
24 netbase <!nocheck>,
25 tzdata <!nocheck>,
26+ tzdata-legacy <!nocheck>,
27 Standards-Version: 4.6.0.1
28 Homepage: https://github.com/influxdata/telegraf
29 Rules-Requires-Root: no

Subscribers

People subscribed via source and target branches