Merge ~mirespace/ubuntu/+source/numactl:merge-lp1946879-numactl-jammy into ubuntu/+source/numactl:debian/sid

Proposed by Miriam España Acebal
Status: Merged
Merge reported by: Miriam España Acebal
Merged at revision: 8a4b83ef6c3f07bdd8f33ba4890dfda37cb75150
Proposed branch: ~mirespace/ubuntu/+source/numactl:merge-lp1946879-numactl-jammy
Merge into: ubuntu/+source/numactl:debian/sid
Diff against target: 84 lines (+45/-2)
4 files modified
debian/changelog (+32/-0)
debian/control (+2/-1)
debian/patches/link-libatomic.diff (+10/-0)
debian/patches/series (+1/-1)
Reviewer Review Type Date Requested Status
Sergio Durigan Junior (community) Approve
Christian Ehrhardt  Pending
Review via email: mp+411017@code.launchpad.net

This proposal supersedes a proposal from 2021-10-29.

Description of the change

Hello team,

PPA for this merge is: ppa:mirespace/merge-lp1946879-numactl-jammy

The delta has only one remaining change.

Usual tags are there:

lp1946879/logical/2.0.14-0ubuntu3
lp1946879/new/debian
lp1946879/old/debian
lp1946879/old/ubuntu
lp1946879/reconstruct/2.0.14-0ubuntu3
lp1946879/split/2.0.14-0ubuntu3

The package hasn't got any DEP 8 packages.
I tested that it installs, it uninstalls and it upgrades properly on jammy:

root@tester-numactl-J:~# lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu Jammy Jellyfish (development branch)
Release: 22.04
Codename: jammy
root@tester-numactl-J:~# dpkg -l numactl
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-==============-===============-============-=========================================
ii numactl 2.0.14-3ubuntu1 amd64 NUMA scheduling and memory placement tool

Thanks in advance for your time reviewing this :)

To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

I can review this one.

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks for the MP, Miriam :-).

The package builds fine locally. As you mentioned, unfortunately it doesn't have dep8 tests.

I found that upstream has applied a similar fix to the -latomic patch we're carrying, but they haven't released a version containing this fix yet. This is a good thing, though, because when they do (and when Debian updates their package), numactl will become a sync again in Ubuntu.

Finally, git-range-diff doesn't show me any problems.

FWIW, I looked at the bugs for numactl and found two old ones. I took the liberty to reply to one of them (https://bugs.launchpad.net/ubuntu/+source/numactl/+bug/1452089), because it seemed to me like it's either a configuration issue or something that's been fixed already. I'm not holding my breath waiting for a reply because the bug has been reported in 2015, but who knows...

Anyway, this LGTM. I'm approving and sponsoring this upload.

$ dput numactl_2.0.14-3ubuntu1_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/numactl/numactl_2.0.14-3ubuntu1_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/numactl/numactl_2.0.14-3ubuntu1.dsc: Valid signature from 106DA1C8C3CBBF14
Package includes an .orig.tar.gz file although the debian revision suggests
that it might not be required. Multiple uploads of the .orig.tar.gz may be
rejected by the upload queue management software.
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading numactl_2.0.14-3ubuntu1.dsc: done.
  Uploading numactl_2.0.14.orig.tar.gz: done.
  Uploading numactl_2.0.14-3ubuntu1.debian.tar.xz: done.
  Uploading numactl_2.0.14-3ubuntu1_source.buildinfo: done.
  Uploading numactl_2.0.14-3ubuntu1_source.changes: done.
Successfully uploaded packages.

review: Approve
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

FWIW, the upstream fix I mentioned above can be found here:

https://github.com/numactl/numactl/commit/e0de0d9e981ddb53bdeb4a4b9dc43046c9ff4ff9

Revision history for this message
Miriam España Acebal (mirespace) wrote :

Thanks a lot Sergio! Always learning new things from you :)

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

 numactl | 2.0.14-3ubuntu1 | jammy | source, amd64, arm64, armhf, i386, ppc64el, riscv64, s390x

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

I can't close or otherwise set it, claiming the team slot to remove it from our overview

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 8b06cd9..3ff54a8 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,11 @@
6+numactl (2.0.14-3ubuntu1) jammy; urgency=medium
7+
8+ * Merge with Debian unstable (LP: #1946879). Remaining changes:
9+ - New patch d/p/link-libatomic.diff: Link with -latomic
10+ to fix ftbfs on riscv64.
11+
12+ -- Miriam España Acebal <miriam.espana@canonical.com> Fri, 29 Oct 2021 13:49:46 +0200
13+
14 numactl (2.0.14-3) unstable; urgency=medium
15
16 * Only install numa.3 in -dev package (Closes: #994821)
17@@ -25,6 +33,30 @@ numactl (2.0.14-1) unstable; urgency=medium
18
19 -- Ian Wienand <ianw@debian.org> Tue, 21 Sep 2021 15:42:03 +1000
20
21+numactl (2.0.14-0ubuntu3) impish; urgency=medium
22+
23+ * No-change rebuild to build packages with zstd compression.
24+
25+ -- Matthias Klose <doko@ubuntu.com> Thu, 07 Oct 2021 12:21:45 +0200
26+
27+numactl (2.0.14-0ubuntu2) hirsute; urgency=medium
28+
29+ * Link with -latomic to fix ftbfs on riscv64.
30+
31+ -- Matthias Klose <doko@ubuntu.com> Tue, 23 Mar 2021 11:40:09 +0100
32+
33+numactl (2.0.14-0ubuntu1) hirsute; urgency=medium
34+
35+ * New upstream version, ready for lto builds.
36+
37+ -- Matthias Klose <doko@ubuntu.com> Tue, 23 Mar 2021 11:07:18 +0100
38+
39+numactl (2.0.12-1build1) groovy; urgency=medium
40+
41+ * No change rebuild to gain CET protection
42+
43+ -- Dimitri John Ledkov <xnox@ubuntu.com> Thu, 18 Jun 2020 19:15:17 +0100
44+
45 numactl (2.0.12-1) unstable; urgency=medium
46
47 * Update to 2.0.12
48diff --git a/debian/control b/debian/control
49index dc01a2b..85cf040 100644
50--- a/debian/control
51+++ b/debian/control
52@@ -1,7 +1,8 @@
53 Source: numactl
54 Section: admin
55 Priority: optional
56-Maintainer: Ian Wienand <ianw@debian.org>
57+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
58+XSBC-Original-Maintainer: Ian Wienand <ianw@debian.org>
59 Uploaders: Al Stone <ahs3@debian.org>
60 Standards-Version: 4.5.1
61 Build-Depends: debhelper (>= 13)
62diff --git a/debian/patches/link-libatomic.diff b/debian/patches/link-libatomic.diff
63new file mode 100644
64index 0000000..55d7ff2
65--- /dev/null
66+++ b/debian/patches/link-libatomic.diff
67@@ -0,0 +1,10 @@
68+--- a/Makefile.am
69++++ b/Makefile.am
70+@@ -41,6 +41,7 @@ memhog_LDADD = libnuma.la
71+
72+ libnuma_la_SOURCES = libnuma.c syscall.c distance.c affinity.c affinity.h sysfs.c sysfs.h rtnetlink.c rtnetlink.h versions.ldscript
73+ libnuma_la_LDFLAGS = -version-info 1:0:0 -Wl,--version-script,$(srcdir)/versions.ldscript -Wl,-init,numa_init -Wl,-fini,numa_fini
74++libnuma_la_LIBADD = -latomic
75+
76+ check_PROGRAMS = \
77+ test/distance \
78diff --git a/debian/patches/series b/debian/patches/series
79index 8b13789..350be78 100644
80--- a/debian/patches/series
81+++ b/debian/patches/series
82@@ -1 +1 @@
83-
84+link-libatomic.diff

Subscribers

People subscribed via source and target branches