Merge ~mirespace/ubuntu/+source/monitoring-plugins:1940916-1827159-jammy-synthetics-fs into ubuntu/+source/monitoring-plugins:ubuntu/jammy-devel
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | c49549297ba971b191d57b6b7a5b595e1a885c6b | ||||
Proposed branch: | ~mirespace/ubuntu/+source/monitoring-plugins:1940916-1827159-jammy-synthetics-fs | ||||
Merge into: | ubuntu/+source/monitoring-plugins:ubuntu/jammy-devel | ||||
Diff against target: |
89 lines (+47/-13) 2 files modified
debian/changelog (+9/-0) debian/patches/exclude-tmpfs-squashfs-tracefs.patch (+38/-13) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Bryce Harrington (community) | Approve | ||
Canonical Server | Pending | ||
Review via email: mp+414956@code.launchpad.net |
Description of the change
This is a clone of [MP 414725](https:/
---
Hello team,
PPA with the package (monitoring-plugins - 2.3.1-1ubuntu4) is here:
sudo add-apt-repository ppa:mirespace/
sudo apt-get update
This bug is a side-effect of bug 1827159, where the synthetic filesystems (tmp, squash, trace) were excluded by default to avoid false positives: if the user wants to explicitly check for this kind of filesystem (including them on command line) or to check a mount point based on some of them, the result was DISK UNKNOWN (as it was excluded by default).
The approach here has been excluding this kind of filesystem only if it's not included via path (-p option) nor by including (-N option).
The code also can be expanded later for another similar kind of filesystems if needed in the future.
The package has no test.
These are the lintian warnings present:
❯ lintian --pedantic
W: monitoring-plugins source: debian-
W: monitoring-plugins source: newer-standards
P: monitoring-plugins source: no-dep5-copyright
P: monitoring-plugins source: package-
P: monitoring-plugins source: rules-requires-
SRU template was filed in the bug with the steps for reproducing, bad and good cases.
Thanks in advance for your time in reviewing this.
Verified this includes the same changes as the focal branch, and builds properly. There are no autopkgtests but verified invoking autopkgtest does not fail.
Looks good, uploading:
$ dput ubuntu ../*source.changes plugins_ 2.3.1-1ubuntu4_ source. changes: Valid signature from E603B2578FB8F0FB plugins_ 2.3.1-1ubuntu4. dsc: Valid signature from E603B2578FB8F0FB plugins_ 2.3.1-1ubuntu4. dsc: done. plugins_ 2.3.1-1ubuntu4. debian. tar.xz: done. plugins_ 2.3.1-1ubuntu4_ source. buildinfo: done. plugins_ 2.3.1-1ubuntu4_ source. changes: done.
D: Setting host argument.
Checking signature on .changes
gpg: ../monitoring-
Checking signature on .dsc
gpg: ../monitoring-
Uploading to ubuntu (via ftp to upload.ubuntu.com):
Uploading monitoring-
Uploading monitoring-
Uploading monitoring-
Uploading monitoring-
Successfully uploaded packages.