Merge ~mirespace/ubuntu/+source/lto-disabled-list:adding-wireshark-for-arm64-lp961901 into ubuntu/+source/lto-disabled-list:ubuntu/jammy-devel

Proposed by Miriam España Acebal
Status: Merged
Merged at revision: 523a6e7e423bc8f8c187c758642a4ab43bccf545
Proposed branch: ~mirespace/ubuntu/+source/lto-disabled-list:adding-wireshark-for-arm64-lp961901
Merge into: ubuntu/+source/lto-disabled-list:ubuntu/jammy-devel
Diff against target: 27 lines (+7/-1)
2 files modified
debian/changelog (+6/-0)
lto-disabled-list (+1/-1)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Approve
Canonical Server Pending
Review via email: mp+416029@code.launchpad.net

Description of the change

Hi team,

ppa for this is:

https://launchpad.net/~mirespace/+archive/ubuntu/lto-disabled-list
sudo add-apt-repository ppa:mirespace/lto-disabled-list
sudo apt-get update

As described in bug 961901, comment #7, we need to disable lto for wireshark on arm64 and s390x as well for avoiding a FTBFS case (it was already for amd64).

Lintian pass in the local build:

Lintian: pass
Machine Architecture: amd64
Package: lto-disabled-list
Package-Time: 130
Source-Version: 22
Space: 192
Status: successful
Version: 22
-----------------

Thanks in advance for your time reviewing this. When this MP is good enough, please tag & sponsor.

To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

There is a blank whitespace @EOL in the changelog.

I'll fix that on upload

Other than that I agree to the approach, now we need to resolve whatever is further blocking s390x tests.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading lto-disabled-list_22.dsc: done.
  Uploading lto-disabled-list_22.tar.xz: done.
  Uploading lto-disabled-list_22_source.buildinfo: done.
  Uploading lto-disabled-list_22_source.changes: done.
Successfully uploaded packages.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 38ac436..ea440fe 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+lto-disabled-list (22) jammy; urgency=medium
7+
8+ * Add wireshark @ arm64 s390x (LP: #1961901)
9+
10+ -- Miriam España Acebal <miriam.espana@canonical.com> Thu, 24 Feb 2022 13:11:15 +0100
11+
12 lto-disabled-list (21) jammy; urgency=medium
13
14 [ Rik Mills ]
15diff --git a/lto-disabled-list b/lto-disabled-list
16index 9dbf455..b6fc528 100644
17--- a/lto-disabled-list
18+++ b/lto-disabled-list
19@@ -1523,7 +1523,7 @@ weston any
20 wine amd64 arm64
21 wine-development amd64 arm64
22 winff s390x
23-wireshark amd64
24+wireshark amd64 arm64 s390x
25 wiringpi any
26 wmwave any
27 wnn6-sdk any

Subscribers

People subscribed via source and target branches