Merge ~mirespace/ubuntu/+source/heimdal:ftbfs-kafs_strlcpy-mantic-lp2036253 into ubuntu/+source/heimdal:ubuntu/mantic-devel

[Miriam España Acebal]

Hi team,

same as for Noble (https://code.launchpad.net/~mirespace/ubuntu/+source/heimdal/+git/heimdal/+merge/457424).

PPA for this is ppa:mirespace/heimdal-ftbfs-lp2036253
                https://launchpad.net/~mirespace/+archive/ubuntu/heimdal-ftbfs-lp2036253

Here I changed the versions of the libraries added in the control file accordingly to mantic versions.

Thank you in advance for your time reviewing this.

[Miriam España Acebal (mirespace)]

(02:55:36 PM) LocutusOfBorg: mirespace, if I can, I'm happy to sponsor
...
(03:06:07 PM) LocutusOfBorg: both sponsored

https://bugs.launchpad.net/ubuntu/+source/heimdal/+bug/2036253/comments/3

[Bryce Harrington (bryce)]

LGTM, +1

review: Approve

[git-ubuntu bot (git-ubuntu-bot)]

Approvers: bryce, mirespace
Uploaders: bryce
MP auto-approved

review: Approve

[Miriam España Acebal (mirespace)]

Hi Bryce,

After detecting some packages that need to be added to the Break too (not only libraries, binary commands too), and that the strict version in symbol files was introducing an unmet dependencies issue for some openafs packages, I'm resubmitting this heimdal mantic package.

I rebuild the openafs package at

ppa:mirespace/openafs-rebuild-lp2046441
https://launchpad.net/~mirespace/+archive/ubuntu/openafs-rebuild-lp2046441/+packages

against the this MP heimdal version here (same that before):

ppa:mirespace/heimdal-ftbfs-lp2036253
https://launchpad.net/~mirespace/+archive/ubuntu/heimdal-ftbfs-lp2036253

and I was able to install aklog from openafs-krb5 [2].

I know that this "mini" transition couldn't be accepted for SRU, because it implies the rebuild of openafs in a supportet but non-development series, but it's only one package to rebuild.

I am writing this for discussion, and I would understand if this did not qualify for SRU.

[1] (https://bugs.launchpad.net/ubuntu/+source/heimdal/+bug/2036253/comments/7)
[2] https://bugs.launchpad.net/ubuntu/+source/openafs/+bug/2046441/comments/1

[Miriam España Acebal (mirespace)]

Gianfranco Costamagna spotted and applied for this the following solution, from Debian:

https://bugs.launchpad.net/ubuntu/+source/heimdal/+bug/2036253/comments/11

He uploaded a new version for mantic that is now in -proposed.

This MP, although approved (thanks!), is no longer needed: please, move it to Rejected or another appropriated status.

Unmerged commits

d3f6515... by Miriam España Acebal on 2023-12-13

changelog 7.8.git20221117.28daf24+dfsg-3ubuntu3

ecaee91... by Miriam España Acebal on 2023-12-13

d/control: Declare Breaks: against older packages using these symbols.

75b9cc6... by Miriam España Acebal on 2023-12-13

  * d/lib{kafs0,roken19}-heimdal.symbols:
      - Make symbol dependencies on libroken19-heimdal and libkafs0-heimdal strict to avoid future symbol skew.

c79a46e... by Miriam España Acebal on 2023-12-13

* d/lib{kafs0,roken19}-heimdal.symbols: _{kafs,rk}_strl{cat,cpy} are
    made optional symbols, since they are not needed when built
    against glibc 2.38.

diff --git a/debian/changelog b/debian/changelog
index 3ce8775..6c3fede 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,15 @@
+heimdal (7.8.git20221117.28daf24+dfsg-3ubuntu1.1) mantic; urgency=medium
+
+  * d/lib{kafs0,roken19}-heimdal.symbols:
+    - _{kafs,rk}_strl{cat,cpy} are made optional symbols, since they
+      are not needed when built against glibc 2.38 (LP: #2036253).
+    - Make symbol dependencies on libroken19-heimdal and
+      libkafs0-heimdal to build-depends on itself.
+  * d/control: Declare Breaks: against older packages (libraries and
+    commands applications) using these symbols.
+
+ -- Miriam España Acebal <[e-mail]>  Wed, 13 Dec 2023 12:13:33 +0100
+
 heimdal (7.8.git20221117.28daf24+dfsg-3ubuntu1) mantic; urgency=medium
 
   * Merge from Debian unstable. Remaining changes:
diff --git a/debian/control b/debian/control
index a42fe7e..87e746b 100644
--- a/debian/control
+++ b/debian/control
@@ -252,6 +252,18 @@ Pre-Depends: ${misc:Pre-Depends}
 Section: libs
 Architecture: any
 Depends: ${misc:Depends}, ${shlibs:Depends}
+Breaks: openafs-client (<< 1.8.10-1ubuntu2~),
+        openafs-dbserver (<< 1.8.10-1ubuntu2~),
+        openafs-fileserver (<< 1.8.10-1ubuntu2~),
+        openafs-fuse (<< 1.8.10-1ubuntu2~),
+        openafs-krb5 (<< 1.8.10-1ubuntu2~),
+        libafsauthent2 (<< 1.8.10-1ubuntu2~),
+        libafsrpc2 (<< 1.8.10-1ubuntu2~),
+        libhdb9-heimdal (<<7.8.git20221117.28daf24+dfsg-3ubuntu1.1~),
+        libhx509-5-heimdal (<<7.8.git20221117.28daf24+dfsg-3ubuntu1.1~),
+        libkadm5srv8-heimdal (<<7.8.git20221117.28daf24+dfsg-3ubuntu1.1~),
+        libkdc2-heimdal (<<7.8.git20221117.28daf24+dfsg-3ubuntu1.1~),
+        libkrb5-26-heimdal (<<7.8.git20221117.28daf24+dfsg-3ubuntu1.1~)
 Description: Heimdal Kerberos - roken support library
  Heimdal is a free implementation of Kerberos 5 that aims to be
  compatible with MIT Kerberos.
diff --git a/debian/libkafs0-heimdal.symbols b/debian/libkafs0-heimdal.symbols
index 648ab4c..eab2806 100644
--- a/debian/libkafs0-heimdal.symbols
+++ b/debian/libkafs0-heimdal.symbols
@@ -1,4 +1,5 @@
 libkafs.so.0 #PACKAGE# #MINVER#
+* Build-Depends-Package: libkafs0-heimdal
  _kafs_afslog_all_local_cells@Base 1.4.0+git20110226
  _kafs_debug@Base 1.4.0+git20110226
  _kafs_derive_des_key@Base 1.7~git20150920
@@ -12,7 +13,7 @@ libkafs.so.0 #PACKAGE# #MINVER#
  _kafs_get_cred@Base 1.4.0+git20110226
  _kafs_realm_of_cell@Base 1.4.0+git20110226
  _kafs_resolve_debug@Base 1.4.0+git20110226
- _kafs_strlcpy@Base 1.4.0+git20110226
+ (optional)_kafs_strlcpy@Base 1.4.0+git20110226
  k_afs_cell_of_file@Base 1.4.0+git20110226
  k_hasafs@Base 1.4.0+git20110226
  k_hasafs_recheck@Base 1.4.0+git20110226
diff --git a/debian/libroken19-heimdal.symbols b/debian/libroken19-heimdal.symbols
index 177457f..0406650 100644
--- a/debian/libroken19-heimdal.symbols
+++ b/debian/libroken19-heimdal.symbols
@@ -1,4 +1,5 @@
 libroken.so.19 #PACKAGE# #MINVER#
+* Build-Depends-Package: libroken19-heimdal
  HEIMDAL_ROKEN_1.0@HEIMDAL_ROKEN_1.0 1.4.0+git20110226
  arg_printusage@HEIMDAL_ROKEN_1.0 1.4.0+git20110226
  arg_printusage_i18n@HEIMDAL_ROKEN_1.0 1.4.0+git20110226
@@ -98,8 +99,8 @@ libroken.so.19 #PACKAGE# #MINVER#
  rk_socket_sockaddr_size@HEIMDAL_ROKEN_1.0 1.4.0+git20110226
  rk_strcollect@HEIMDAL_ROKEN_1.0 1.4.0+git20110226
  rk_strerror_r@HEIMDAL_ROKEN_1.0 1.4.0+git20110226
- rk_strlcat@HEIMDAL_ROKEN_1.0 1.4.0+git20110226
- rk_strlcpy@HEIMDAL_ROKEN_1.0 1.4.0+git20110226
+ (optional)rk_strlcat@HEIMDAL_ROKEN_1.0 1.4.0+git20110226
+ (optional)rk_strlcpy@HEIMDAL_ROKEN_1.0 1.4.0+git20110226
  rk_strlwr@HEIMDAL_ROKEN_1.0 1.4.0+git20110226
  rk_strpoolcollect@HEIMDAL_ROKEN_1.0 1.4.0+git20110226
  rk_strpoolfree@HEIMDAL_ROKEN_1.0 1.4.0+git20110226