Merge lp:~mir-team/mir/workaround-for-valgrind-opcode into lp:mir

[Brandon Schaefer]

Explicitly use "/dev/urandom" vs the default __x86_rdrand() which seems to cause opcode issues.

This is a WORKAROUND until this is fixed:
https://bugs.launchpad.net/ubuntu/+source/valgrind/+bug/1501545

This work around is for errors that only happen on amd64:
http://s-jenkins.ubuntu-ci:8080/job/mir-wily-amd64-ci/1225/console

Invalid op code from valgrinds latest release.

Error started happening here:
http://s-jenkins.ubuntu-ci:8080/job/mir-wily-amd64-ci/
Failed > Console Output #1225 Sep 30, 2015 3:21:48 PM
Success > Console Output #1224 Sep 30, 2015 2:07:47 PM

New valgrind release:
 -- Matthias Klose <email address hidden> Wed, 30 Sep 2015

Still dont know what exactly is causing the issue with valgrind.

ci-testing passed:
http://s-jenkins.ubuntu-ci:8080/job/mir-wily-amd64-ci/1236/console

[Alberto Aguirre (albaguirre)]

Sounds plausible...

valgrind may have updated it's cpuid info?

review: Approve

[Alberto Aguirre (albaguirre)]

FIY, the opcode is "rdrand %eax"

[Alberto Aguirre (albaguirre)]

s/FIY/FYI

[Brandon Schaefer (brandontschaefer)]

Bug:
https://bugs.launchpad.net/ubuntu/+source/valgrind/+bug/1501545

[Chris Halse Rogers (raof)]

LGTM

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:2979
http://jenkins.qa.ubuntu.com/job/mir-ci/5084/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/4206
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3113
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4148/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-wily-touch/106/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1237
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1237/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/106/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4149
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4149/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/6825/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/23819
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-wily-armhf/107/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5084/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:2979
http://jenkins.qa.ubuntu.com/job/mir-ci/5085/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/4207
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3114
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4149
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-wily-touch/107/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1239
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1239/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/107/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4150
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4150/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/6826
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/23824
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-wily-armhf/108/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5085/rebuild

review: Approve (continuous-integration)

[Daniel van Vugt (vanvugt)]

Another one. I guess we should be thankful these are rare. And normally it's just valgrind on armhf...

review: Approve

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:2979
http://jenkins.qa.ubuntu.com/job/mir-ci/5087/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/4209
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3116
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4151
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-wily-touch/109/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1241
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1241/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/109/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4152
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4152/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/6828
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/23828
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-wily-armhf/110/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5087/rebuild

review: Approve (continuous-integration)

=== modified file 'tests/mir_test_framework/testing_server_options.cpp'
--- tests/mir_test_framework/testing_server_options.cpp	2015-06-17 05:20:42 +0000
+++ tests/mir_test_framework/testing_server_options.cpp	2015-09-30 23:16:32 +0000
@@ -50,7 +50,7 @@
 
 std::string create_random_socket_name()
 {
-    std::random_device random_device;
+    std::random_device random_device("/dev/urandom");
     std::mt19937 generator(random_device());
     int max_concurrent_test_instances = 99999;
     std::uniform_int_distribution<> dist(1, max_concurrent_test_instances);