Mir

Code review comment for lp:~mir-team/mir/lazy-cookie-secret-creation

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

You're only deferring the problem and not solving it. This branch simply moves the hang/crash to a later location where the regression tests don't cover it any more.

So you need new regression tests to cover the new code here, and to prove that at no stage during executing does Mir hang indefinitely or crash due to lack of entropy.

Needs fixing: No test coverage

also Disapprove: The best you can achieve this with approach is to move the hang+crash to a later location. And that's still not acceptable.

review: Disapprove

« Back to merge proposal