lp:~mir-team/mir/handle-mis-shaped-cookies

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:mir

Alan Griffiths: Disapprove on 2016-02-09

Daniel van Vugt: Abstain on 2016-02-09

PS Jenkins bot (community): Approve (continuous-integration) on 2016-02-04

Mir CI Bot: Approve (continuous-integration) on 2016-02-04

Andreas Pokorny (community): Approve on 2016-02-04

Diff: 249 lines (+203/-3)

4 files modified

src/server/input/default_event_builder.cpp (+4/-2)
src/server/input/key_repeat_dispatcher.cpp (+2/-1)
tests/acceptance-tests/CMakeLists.txt (+1/-0)
tests/acceptance-tests/test_server_cookie_authority.cpp (+196/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1536662: [regression] Black screen: Mir hangs and then crashes on startup/login due to reading from /dev/random

Critical

Fix Released

Link a bug report

Related blueprints

3279. By Brandon Schaefer on 2016-02-04

* Fix test names
* Use wait cond vs spin wait

3278. By Brandon Schaefer on 2016-02-03

* Dont change that space

3277. By Brandon Schaefer on 2016-02-03

* Test we can override a stub cookie factory and accept cookie size thats less then our internal storage size

3276. By Brandon Schaefer on 2016-02-03

* The current test, some strange hangup on a surface release or thread join (if you skip the release)

3275. By Brandon Schaefer on 2016-01-29

* We throw on NULL cookies and handle empty/large cookies now

3274. By Alan Griffiths on 2016-01-27

compositor, scene: track which outputs are "damaged" by buffer posts. Fixes: https://bugs.launchpad.net/bugs/1532202.

Approved by Kevin DuBois, Brandon Schaefer, Alexandros Frantzis, PS Jenkins bot, mir-ci-bot.

3273. By Alan Griffiths on 2016-01-26

logging: Human readable timestamps in DumbConsoleLogger.

Approved by Brandon Schaefer, PS Jenkins bot, mir-ci-bot, Kevin DuBois.

3272. By Alan Griffiths on 2016-01-26

Add MIR_USE_LD_GOLD build option.

Approved by PS Jenkins bot, mir-ci-bot, Alberto Aguirre, Brandon Schaefer.

3271. By Brandon Schaefer on 2016-01-26

Fix the flakey tests, and actually make a test test something.

Approved by Andreas Pokorny, Kevin DuBois, mir-ci-bot, PS Jenkins bot.

3270. By Brandon Schaefer on 2016-01-26

mir-cookie: Use a constant time memcmp to verify cookie contents

Additionally use the full SHA1 size of 160 bits for the cookie MAC.

Approved by PS Jenkins bot, Kevin DuBois, Alberto Aguirre.