Mir

Merge lp:~mir-team/mir/bump-deb-changelog16-mirserver8 into lp:mir

Proposed by kevin gunn
Status: Merged
Approved by: kevin gunn
Approved revision: no longer in the source branch.
Merged at revision: 1145
Proposed branch: lp:~mir-team/mir/bump-deb-changelog16-mirserver8
Merge into: lp:mir
Diff against target: 68 lines (+11/-5)
5 files modified
CMakeLists.txt (+1/-1)
debian/changelog (+6/-0)
debian/control (+2/-2)
debian/libmirserver8.install (+1/-1)
src/server/CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp:~mir-team/mir/bump-deb-changelog16-mirserver8
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
PS Jenkins bot (community) continuous-integration Approve
Chris Halse Rogers Approve
Review via email: mp+191548@code.launchpad.net

Commit message

bump mir deb changelog to 0.0.16 and libmirserver8

Description of the change

bump mir deb changelog to 0.0.16 and libmirserver8

To post a comment you must log in.
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

The date in the version string needs updating:
19 +mir (0.0.16+13.10.20131011-0ubuntu1) UNRELEASED; urgency=low

review: Needs Fixing
Revision history for this message
Chris Halse Rogers (raof) wrote :

Do we need to include the previous “bump version 0.0.X” changelog entries? They like needless clutter.

That nit out of the way, LGTM.

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Your changelog incorrectly mentions the 0.0.15 and 0.0.16 bumps in the same version. Compare:
  http://bazaar.launchpad.net/~mir-team/mir/bump-deb-changelog16-mirserver8/view/head:/debian/changelog
  http://bazaar.launchpad.net/~mir-team/mir/trunk/view/head:/debian/changelog
Try merging from lp:mir first and then "dch -i" to create a fresh entry for 0.0.16...

Also, there's no need for a date in there. It would be nicer to have:
+mir (0.0.16-0ubuntu1) UNRELEASED; urgency=low

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Yeah that works for now.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2013-10-15 02:59:59 +0000
3+++ CMakeLists.txt 2013-10-17 04:38:55 +0000
4@@ -28,7 +28,7 @@
5
6 set(MIR_VERSION_MAJOR 0)
7 set(MIR_VERSION_MINOR 0)
8-set(MIR_VERSION_PATCH 15)
9+set(MIR_VERSION_PATCH 16)
10
11 set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${CMAKE_CURRENT_SOURCE_DIR}/cmake)
12
13
14=== modified file 'debian/changelog'
15--- debian/changelog 2013-10-17 04:27:22 +0000
16+++ debian/changelog 2013-10-17 04:38:55 +0000
17@@ -1,3 +1,9 @@
18+mir (0.0.16+13.10.20131016-0ubuntu1) UNRELEASED; urgency=low
19+
20+ * bump version 0.0.16
21+
22+ -- Kevin Gunn <kevin.gunn@canonical.com> Wed, 16 Oct 2013 23:35:28 -0500
23+
24 mir (0.0.15+13.10.20131014-0ubuntu1) saucy; urgency=low
25
26 [ Kevin Gunn ]
27
28=== modified file 'debian/control'
29--- debian/control 2013-10-15 02:59:59 +0000
30+++ debian/control 2013-10-17 04:38:55 +0000
31@@ -69,7 +69,7 @@
32 .
33 Contains the protocol's definition files.
34
35-Package: libmirserver7
36+Package: libmirserver8
37 Section: libs
38 Architecture: i386 amd64 armhf arm64
39 Multi-Arch: same
40@@ -115,7 +115,7 @@
41 Architecture: i386 amd64 armhf arm64
42 Multi-Arch: same
43 Pre-Depends: ${misc:Pre-Depends}
44-Depends: libmirserver7 (= ${binary:Version}),
45+Depends: libmirserver8 (= ${binary:Version}),
46 libmirprotobuf-dev (= ${binary:Version}),
47 mircommon-dev (= ${binary:Version}),
48 libglm-dev,
49
50=== renamed file 'debian/libmirserver7.install' => 'debian/libmirserver8.install'
51--- debian/libmirserver7.install 2013-10-15 02:59:59 +0000
52+++ debian/libmirserver8.install 2013-10-17 04:38:55 +0000
53@@ -1,1 +1,1 @@
54-usr/lib/*/libmirserver.so.7
55+usr/lib/*/libmirserver.so.8
56
57=== modified file 'src/server/CMakeLists.txt'
58--- src/server/CMakeLists.txt 2013-10-15 02:59:59 +0000
59+++ src/server/CMakeLists.txt 2013-10-17 04:38:55 +0000
60@@ -88,7 +88,7 @@
61 )
62 endif()
63
64-set(MIRSERVER_ABI 7)
65+set(MIRSERVER_ABI 8)
66
67 set_target_properties(
68 mirserver

Subscribers

People subscribed via source and target branches