Disable WLCS tests on LP/arm* (as they are currently flaky)
a28e8cd...
by
"bors[bot]" <26634292+bors[bot]@users.noreply.github.com>
Merge #2485
2485: SurfaceChangeNotification: make threadsafe r=AlanGriffiths a=wmww
There's still a possibility a surface move will get processed out of order with a buffer submit, but since a surface move generates a full scene change that invalidates everything that should be fine.
Co-authored-by: Sophie Winter <email address hidden>
ac61b33...
by
Sophie Winter <email address hidden>
SurfaceChangeNotification: make threadsafe
a722c37...
by
"bors[bot]" <26634292+bors[bot]@users.noreply.github.com>
Merge #2482
2482: Surface: Drop some cursor_stream detritus left over from mirclient r=AlanGriffiths a=RAOF
Co-authored-by: Christopher James Halse Rogers <email address hidden>
ab9a310...
by
"bors[bot]" <26634292+bors[bot]@users.noreply.github.com>
Merge #2478 #2481
2478: github: use canonical/actions/build-snap r=AlanGriffiths a=Saviq
2481: Refactor scene and surface change notification classes r=AlanGriffiths a=wmww
For presumably historical reasons, we previously had `LegacySceneChangeNotification`, which used either `LegacySurfaceChangeNotification` or `NonLegacySurfaceChangeNotification` depending on how it was constructed. Production code only used the non-legacy path, and the non-legacy one inherited from the legacy one. This PR consolidates the surface observers into a single class, and drops the legacy prefix from both surface and scene observers. It should not have any impact on behavior.
Co-authored-by: Michał Sawicz (Saviq) <email address hidden>
Co-authored-by: Sophie Winter <email address hidden>
e14050d...
by
"bors[bot]" <26634292+bors[bot]@users.noreply.github.com>
Surface: Drop some cursor_stream detritus left over from mirclient
3d4f5c0...
by
"bors[bot]" <26634292+bors[bot]@users.noreply.github.com>
Merge #2470
2470: Send changed area to frame posted notification r=RAOF a=wmww
The surface observer's `frame_posted()` notification is current given the size of the posted frame. The only use of this info seems to be in `NonLegacySurfaceChangeNotification`, where it is used in conjunction with the surface's position to determine an area of the screen that has changed. Unfortunately, the way this is done is broken in many ways. Scaled surfaces, streams with offsets from the surface and surfaces with margins will all cause it to report an incorrect damage rectangle.
With this PR, the actual area of the screen which is effected is reported, and all of the above cases are handled correctly and tested.
Co-authored-by: Sophie Winter <email address hidden>
a505af8...
by
Sophie Winter <email address hidden>
Update SceneChangeNotification tests
aff026a...
by
Sophie Winter <email address hidden>
Drop 'Legacy' from the names of surface and scene change observation classes