Merge lp:~milo/linaro-patchmetrics/bug1012538 into lp:linaro-patchmetrics
Proposed by
Milo Casagrande
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 370 | ||||
Proposed branch: | lp:~milo/linaro-patchmetrics/bug1012538 | ||||
Merge into: | lp:linaro-patchmetrics | ||||
Diff against target: |
70 lines (+31/-10) 1 file modified
apps/patchmetrics/utils.py (+31/-10) |
||||
To merge this branch: | bzr merge lp:~milo/linaro-patchmetrics/bug1012538 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Deepti B. Kalakeri (community) | Approve | ||
Review via email: mp+112087@code.launchpad.net |
Description of the change
Hi,
I'm proposing the following merge in order to address, if not completely, the 503 HTTP error we sometimes get from Launchpad. Since we cannot make anything else about it, I added a retry loop with a sleep timeout in order to have a little bit of time between one retry and the other.
At the moment, the retries are fixed at a maximum of 3, and the timeout is set to 30 seconds.
To post a comment you must log in.
I guess the bug https:/ /bugs.launchpad .net/linaro- patchmetrics/ +bug/967290 mentioned in the following
code is not fixed yet . Have you tested this, that email parsing code does not insert any invalid email address in the first place ?
69 + else: /bugs.launchpad .net/linaro- patchmetrics/ +bug/967290 warning( "Launchpad rejected email lookup and "
70 + # XXX We should not encounter bad email addresses.
71 + #https:/
72 + person = None # Launchpad lookup failed.
73 + logger.
74 + "returned HTTPError. Offending email "
75 + "address: %s" % email)
If the above code has been tested for bug https:/ /bugs.launchpad .net/linaro- patchmetrics/ +bug/967290 to be fixed, then everything looks good +1.
Also, use FIXME: instead of XXX when you merge this code.