Code review comment for lp:~milo/linaro-image-tools/var-refactoring

Revision history for this message
James Tunnicliffe (dooferlad) wrote :

Looks fine, though I wonder if it is worth picking up more:

46 @@ -547,7 +548,7 @@
47 lowmem_opt = ''
48 boot_snippet = 'root=%s' % rootfs_id
49 if is_live:
50 - serial_opts += ' %s' % self.live_serial_opts
51 + serial_opts += ' %s' % self.live_serial_options
52 boot_snippet = 'boot=casper'
53 if is_lowmem:
54 lowmem_opt = 'only-ubiquity'

I would change the local serial_opts variable to be consistent. There are a few places in android_boards where serial_opts turns up as well.

« Back to merge proposal