Code review comment for lp:~milo/linaro-image-tools/dtb-files-support

Revision history for this message
Milo Casagrande (milo) wrote :

Hey James,

thanks for taking a look.

On Mon, Oct 1, 2012 at 5:14 PM, James Tunnicliffe
<email address hidden> wrote:
> Review: Approve
>
> Looks good.
>
> It would be nice if we could combine all the static files copying code into one place. This is similar to the boot files copying that we do, but not the same as copy_files (since those files stay in their packages).
>
> There is definitely room for tidying up that whole code area, but a bug fix isn't the place for it. If you have nothing else to do I am sure it will be... entertaining :-)

Indeed, I wanted to combine them, but it would have been a little bit
too much for the bug report.
I will indeed try to do it during this maintenance cycle, maybe in a
separate bug.

Ciao.

--
Milo Casagrande
Infrastructure Engineer
Linaro.org <www.linaro.org> │ Open source software for ARM SoCs

« Back to merge proposal