Code review comment for lp:~milo/linaro-image-tools/bug1054422

Revision history for this message
Milo Casagrande (milo) wrote :

Hi Danilo,

thanks for the review.

On Mon, Sep 24, 2012 at 9:18 PM, Данило Шеган <email address hidden> wrote:
>
> However small the other fixes are, we should generally strive to keep them in separate branches, especially for things where we plan to do a last-minute re-rollout of the tarball: it would be much better to include only relevant changes (it's not going to be obvious what's going on in the commit log if you lump these three changes together, no matter how verbose you make the commit message; it's neither going to be clear why were the other two changes critical and that they needed a .1 release :).

Yeah, I know, I was not sure to include them here.
I can merge only the two commits for the bug fix, and after the
rollout merge the remaining two with the small fixes.

--
Milo Casagrande
Infrastructure Engineer
Linaro.org <www.linaro.org> │ Open source software for ARM SoCs

« Back to merge proposal