Code review comment for lp:~milo/linaro-ci/external-fragments

Revision history for this message
Deepti B. Kalakeri (deeptik) wrote :

Overall changes looks good +1.
As dicussed on IRC I believe the changes are tested by Andrey and it is believed to work fine.

Can probably make the following changes when u merge it the changes.
It would be good if we made a note how the example values to these options would look like in the scripts probably better to have it in the jenkins_kernel_build_inst.
There is a small spell mistake in a comment at line 8 of the jenkins_common_lib, it should be Default instead of Defaul. ;)

review: Approve

« Back to merge proposal