Code review comment for lp:~milo/linaro-ci/bug1090416

On Fri, Dec 21, 2012 at 12:34 PM, Deepti B. Kalakeri
<email address hidden> wrote:
> Review: Needs Fixing
>
> 283 +elif test -n "$boards" -a -n "$board_type"; then
> 284 + board_types="$board_types,$board_type"
>
> Typo error: elseif needs to be "elif test -n "$board_types" -a -n "$board_type"; than the above
> between, I don't know why would anyone want to define board_types and board_type together in a job, instead if someone needed to define multiple board_types then they could just use board_types param or if they needed single board testing then they can use only board_type. I feel they are compliment params.

They are, or well should be: just one of them should be defined in the
job. Actually, it has been done in that way, introducing
'board_types', not to drop support for all the jobs that are already
using 'board_type'. Or we could just use 'board_type' even for
multiple boards.
All the if-elif code is just for using 'board_types' in the script,
and looping other it, instead of exporting both of them and having to
test which one is defined or not later.

--
Milo Casagrande
Infrastructure Engineer
Linaro.org <www.linaro.org> │ Open source software for ARM SoCs