Merge lp:~milo/linaro-ci/bug1034288 into lp:linaro-ci

Proposed by Milo Casagrande
Status: Merged
Merged at revision: 98
Proposed branch: lp:~milo/linaro-ci/bug1034288
Merge into: lp:linaro-ci
Diff against target: 48 lines (+15/-1)
3 files modified
node/setup-oneiric-node (+1/-0)
node/setup-precise-node (+1/-0)
node/setup_lib (+13/-1)
To merge this branch: bzr merge lp:~milo/linaro-ci/bug1034288
Reviewer Review Type Date Requested Status
Fathi Boudra Approve
Deepti B. Kalakeri Pending
Paul Sokolovsky Pending
Linaro Infrastructure Pending
Review via email: mp+126676@code.launchpad.net

Description of the change

The MP adds a new function in the setup_lib bash file, in order to install more recent version of Linaro Image Tools.
Updated also the node scripts.

To post a comment you must log in.
Revision history for this message
Fathi Boudra (fboudra) wrote :

Some minor fixes:
1) Add the function call where we need it (Oneiric/Precise node). Skip Natty node for now.
2) Rename install_lit to lit_install for consistency with live_build_install.
3) Call the function between live_build_install and git_config, to keep the packages installation block together.
4) VERSION should contains the debian version i.e. 2012.09.1-0ubuntu1~linaro1
5) use a single wget i.e. wget "${DOWNLOAD_URL}${DEB_FILE} ${DOWNLOAD_URL}${PYTHON_LIT}"

Thanks!

review: Needs Fixing
lp:~milo/linaro-ci/bug1034288 updated
100. By Milo Casagrande

Removed installation of l-i-t from natty node.

101. By Milo Casagrande

Fixed version variable, wget line, and wrong variable use.

102. By Milo Casagrande

Renamed function, moved function calls in the nodes.

Revision history for this message
Milo Casagrande (milo) wrote :

Hi Fathi,

thanks for the review.

> Some minor fixes:
> 1) Add the function call where we need it (Oneiric/Precise node). Skip Natty
> node for now.
> 2) Rename install_lit to lit_install for consistency with live_build_install.
> 3) Call the function between live_build_install and git_config, to keep the
> packages installation block together.
> 4) VERSION should contains the debian version i.e. 2012.09.1-0ubuntu1~linaro1
> 5) use a single wget i.e. wget "${DOWNLOAD_URL}${DEB_FILE}
> ${DOWNLOAD_URL}${PYTHON_LIT}"

this is all done.
Just a note on the wget call: it needs to have two separate "strings" (wget "URL1" "URL2").

Revision history for this message
Fathi Boudra (fboudra) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'node/setup-oneiric-node'
2--- node/setup-oneiric-node 2012-08-07 14:37:21 +0000
3+++ node/setup-oneiric-node 2012-09-28 07:06:18 +0000
4@@ -28,6 +28,7 @@
5 uboot-mkimage
6
7 live_build_install
8+lit_install
9 git_config
10
11 if test -e /tmp/fifo3; then
12
13=== modified file 'node/setup-precise-node'
14--- node/setup-precise-node 2012-08-16 04:56:33 +0000
15+++ node/setup-precise-node 2012-09-28 07:06:18 +0000
16@@ -55,6 +55,7 @@
17 zsync
18
19 live_build_install
20+lit_install
21 git_config
22
23 if test -e /tmp/fifo3; then
24
25=== modified file 'node/setup_lib'
26--- node/setup_lib 2012-06-19 09:50:30 +0000
27+++ node/setup_lib 2012-09-28 07:06:18 +0000
28@@ -45,7 +45,19 @@
29 git config --system http.proxy http://ci.linaro.org:3128
30 }
31
32-
33+# Installs the correct linaro-image-tools and python-linaro-image-tools
34+# versions.
35+# The deb files are taken from the ubuntu-build-production archive:
36+# https://launchpad.net/~linaro-infrastructure/+archive/ubuntu-build-production
37+lit_install()
38+{
39+ VERSION='2012.09.1-0ubuntu1~linaro1'
40+ DOWNLOAD_URL="https://launchpad.net/~linaro-infrastructure/+archive/ubuntu-build-production/+files/"
41+ LIT_DEB="linaro-image-tools_${VERSION}_all.deb"
42+ PYTHON_LIT="python-linaro-image-tools_${VERSION}_all.deb"
43+ wget "${DOWNLOAD_URL}${LIT_DEB}" "${DOWNLOAD_URL}${PYTHON_LIT}"
44+ dpkg -i ${LIT_DEB} ${PYTHON_LIT}
45+}
46
47 fifo_cleanup()
48 {

Subscribers

People subscribed via source and target branches