Code review comment for lp:~milo/linaro-ci-dashboard/views-refactoring

Revision history for this message
Stevan Radaković (stevanr) wrote :

The code looks great. Two small comments:

1 === modified file 'HACKING'
2 --- HACKING 2012-09-07 10:39:47 +0000
3 +++ HACKING 2012-09-11 07:31:18 +0000
4 @@ -49,6 +49,66 @@
5
6 Tests should be written and defined inside each sub-application.
7
8 +== Class Hierarchy ==
9 +
10 +=== Templates & Views ===
11 +
12 +The `frotend' base application includes the general HTML Django templates that
13 +each sub-application should base itself on. These templates are stored in the
14 +`frontend/templates/' directory.

Small typo on the froNtend application name.

131 raise ValidationError("With build of type 'Android Toolchain "
132 - "Linaro, it is necessary to specify "
133 + "Linaro', it is necessary to specify "
134 "GCC URL.")

I think this here single quote is to necessary because of the first on wich opens up at the 'Android Toolchain Linaro'.
Or the one before Android should be deleted as well.

« Back to merge proposal