Code review comment for lp:~milo/linaro-ci-dashboard/views-refactoring

Revision history for this message
Milo Casagrande (milo) wrote :

This is moslty all that there is.

For the "build" part, I tried a couple of different approaches, but none really worked. Using even the get_model static method, we need to recunstruct the model from the class, so or we override __init__ or create some custom methods for each loop. I still think that defining for each loop the build URL and a basic build_view is probably better than having the heavily depend on getattr.

There might still be some tweaks to do in the future if we insert ManyToMany fields or other relationship fields in the model and we need to show them, since we will need to traverse the PK and get the real values.

« Back to merge proposal