Merge lp:~milo/linaro-ci-dashboard/updated-xml-definition into lp:linaro-ci-dashboard

Proposed by Milo Casagrande
Status: Merged
Merged at revision: 38
Proposed branch: lp:~milo/linaro-ci-dashboard/updated-xml-definition
Merge into: lp:linaro-ci-dashboard
Diff against target: 33 lines (+11/-8)
1 file modified
HACKING (+11/-8)
To merge this branch: bzr merge lp:~milo/linaro-ci-dashboard/updated-xml-definition
Reviewer Review Type Date Requested Status
Stevan Radaković Approve
Данило Шеган Pending
Linaro Infrastructure Pending
Review via email:

Description of the change

After discussion with Danilo, updated and modified the XML and its DTD definitions.

To post a comment you must log in.
Revision history for this message
Stevan Radaković (stevanr) wrote :

Looks good.
Approve +1.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'HACKING'
2--- HACKING 2012-08-30 10:08:13 +0000
3+++ HACKING 2012-09-04 13:50:37 +0000
4@@ -62,18 +62,21 @@
6 <?xml version="1.0" encoding="UTF-8"?>
7 <!DOCTYPE loop [
8- <!ATTLIST loop (name, type) PCDATA #REQUIRED>
9- <!ATTLIST loop (next) CDATA #OPTIONAL>
10+ <!ELEMENT loop (name,restricted?,official?,description?,fields)>
11+ <!ATTLIST loop type CDATA #REQUIRED>
12+ <!ELEMENT name (#PCDATA)>
13+ <!ELEMENT restricted EMPTY>
14+ <!ELEMENT official EMPTY>
15 <!ELEMENT description (#PCDATA)>
16- <!ELEMENT restricted (#PCDATA)>
17- <!ELEMENT official (#PCDATA)>
18 <!ELEMENT fields (field+)>
19 <!ELEMENT field (#PCDATA)>
20- <!ATTLIST field (name, type) PCDATA #REQUIRED>
21+ <!ATTLIST field name CDATA #REQUIRED>
22+ <!ATTLIST field type (text|int|bool) "text">
23 ]>
24-<loop name="" type="" next="">
25- <restricted></restricted>
26- <official></official>
27+<loop type="">
28+ <name></name>
29+ <restricted/>
30+ <official/>
31 <fields>
32 <field name="" type=""></field>
33 <field name="" type=""></field>


People subscribed via source and target branches