Merge lp:~milo/linaro-ci-dashboard/textfield-loop into lp:linaro-ci-dashboard

[Milo Casagrande]

Here there is the implementation of a generic text-field loop and AndroidTextFieldLoop.

I added a new model inside 'frontend/models' called TextFieldLoop, that is the generic model inheriting from Loop. AndroidTextFieldLoop instead is a new sub-app, which inherits from TextFieldLoop.

In AndroidTextFieldLoop there is also initial support for the 'can_chain_with' static method.
WRT this last point, at the moment I added some other methods in order to achieve class instantiation starting from a string. They are not used for now, and are in for review.

What 'can_chain_with' returns is a list of tuples, tuples defined in the 'loop_reference' file inside 'frontend/models/'. Each tuple consists of: (VISIBLE_NAME, MODULE_PATH.CLASS). There is an additional class, always in 'frontend/models/' called LoopFactory, with a static method, that from a string returns the corresponding class (this is a class object, it is not the real object, that needs to be instantiated later). These are just ideas on how to possibly implement this. I do not really like the part about hardcoding the module path, but at the moment I couldn't find another solution.

[Stevan Radaković (stevanr)]

Hmmm, before addressing other stuff I'd like to discuss your loop_reference logic.
I don't understand the purpose of it nor why would we need the paths to our models.
The only usage of the can_chain_with method is to (in the end) get all the loops which are 'chainable' to the specific loop.
If can_chain_with returns the class names only in a simple list (we can track 'all' our class names in settings or separate class like you already have, but this is not really needed), then in a method we talked about (i.e. get_all_chainable) we would just query all loops with that specific types:
i.e.
def get_all_chainable(self):
  loops = Loop.objects.get(type=[self.get_child_object().can_chain_with()])

where get_all_chainable is part of the Loop model.
I may be missing something here but I rly don't see the need of having class paths.

review: Needs Information

[lp:~milo/linaro-ci-dashboard/textfield-loop]

33. By Milo Casagrande on 2012-08-31

Renamed method, removed path reference and display name.

[Milo Casagrande (milo)]

As per discussion on IRC, store only the class name in 'loop_reference', removed also the display name.

[lp:~milo/linaro-ci-dashboard/textfield-loop]

34. By Milo Casagrande on 2012-08-31

Removed loop_factory class.

35. By Milo Casagrande on 2012-08-31

Update loop_reference comments.

[Stevan Radaković (stevanr)]

Looks much better.
Approve +1

review: Approve

[lp:~milo/linaro-ci-dashboard/textfield-loop]

36. By Milo Casagrande on 2012-08-31

Added missing newlines.

37. By Milo Casagrande on 2012-08-31

Merged from trunk.

38. By Milo Casagrande on 2012-08-31

Fixed migrations file.

39. By Milo Casagrande on 2012-08-31

Excluded 'type' from android text loop.