Merge lp:~milo/linaro-ci-dashboard/textfield-complete into lp:linaro-ci-dashboard

Proposed by Milo Casagrande
Status: Merged
Approved by: Stevan Radaković
Approved revision: 37
Merged at revision: 37
Proposed branch: lp:~milo/linaro-ci-dashboard/textfield-complete
Merge into: lp:linaro-ci-dashboard
Diff against target: 0 lines
To merge this branch: bzr merge lp:~milo/linaro-ci-dashboard/textfield-complete
Reviewer Review Type Date Requested Status
Stevan Radaković Approve
Linaro Infrastructure Pending
Данило Шеган Pending
Review via email:

Description of the change

This is the almost complete version of the textfield loop. The other missing methods will be worked on in the next WI.
Here there is the basic method for converting the inserted values into a dictionary.

Assumption has been made that the default delimiter for key<>value pairs is the '=' char.

I refactored a little bit the checks on the valid values written in the textfield iteself, this was needed for the tests. Tests that are now in.

To post a comment you must log in.
Revision history for this message
Stevan Radaković (stevanr) wrote :

Thanks for working on this Milo it looks great.
One thing though, your tests are not executed at all with 'make test', Makefile should be updated to include this as well.
Other then that, approve +1.

review: Approve
38. By Milo Casagrande

Added tests to Makefile.

39. By Milo Casagrande

Merged from trunk.

40. By Milo Casagrande

Fixed regression on tests.

41. By Milo Casagrande

Fixed problem with migrations files.

Preview Diff



People subscribed via source and target branches