linaro-ci-dashboard

Merge lp:~milo/linaro-ci-dashboard/better-xml into lp:linaro-ci-dashboard

  1. better-xml
  2. Merge into trunk
Proposed by Milo Casagrande
Status: Merged
Merged at revision: 39
Proposed branch: lp:~milo/linaro-ci-dashboard/better-xml
Merge into: lp:linaro-ci-dashboard
Diff against target: 0 lines
To merge this branch: bzr merge lp:~milo/linaro-ci-dashboard/better-xml
Reviewer Review Type Date Requested Status
Stevan Radaković Approve
Данило Шеган Pending
Linaro Infrastructure Pending
Review via email: mp+122861@code.launchpad.net

Description of the change

Updated and simplified a little bit the XML definition.

To post a comment you must log in.
Revision history for this message
Stevan Radaković (stevanr) wrote :

Looks good.
I thought danilos' suggestion was to move everything to be generic and set through 'fields' but I guess we can go like this as well.
Approve +1.

review: Approve
Revision history for this message
Milo Casagrande (milo) wrote :

On Wed, Sep 5, 2012 at 4:03 PM, Stevan Radaković
<email address hidden> wrote:
> Review: Approve
>
> Looks good.
> I thought danilos' suggestion was to move everything to be generic and set through 'fields' but I guess we can go like this as well.
> Approve +1.

You are right, and I was supposed to do exactly like that.
Will updated the DTD and the example with that too.

--
Milo Casagrande
Infrastructure Engineer
Linaro.org <www.linaro.org> │ Open source software for ARM SoCs

lp:~milo/linaro-ci-dashboard/better-xml updated
40. By Milo Casagrande

Simplified the DTD.

Preview Diff

Empty

Subscribers

People subscribed via source and target branches