Code review comment for lp:~milo/lava-tool/lava-167

On Thu, Jun 13, 2013 at 4:24 PM, Antonio Terceiro
<email address hidden> wrote:
>
> It cannot be the first of search_path. Say you write to user_config_path
> (~user/.config/...). For some(most?) devices, at the moment you need to
> run the dispatcher as root. The dispatcher will then look at
> ~root/config/... , and will not find anything the device.
>
> Also, picking some path in search_path involves the (small, but
> non-zero) risk of writing to the default_config_path, what we don't want.
>
> Maybe we could just export [system_config_path, user_config_path] as
> lava_dispatcher.config.write_search_path, then, keep your logic of find
> the first?

I fixed this using your latest changes in the dispatcher.
I also added a test when editing the config file to check if it is
writable or not.

--
Milo Casagrande | Automation Engineer
Linaro.org <www.linaro.org> │ Open source software for ARM SoCs