Code review comment for lp:~milo/lava-tool/lava-165

Revision history for this message
Milo Casagrande (milo) wrote :

On Wed, Jul 24, 2013 at 3:16 PM, Antonio Terceiro
<email address hidden> wrote:
> Agreed. We only have to consider whether we expect people to edit that
> file manually or not, because the serialization of the entire file in
> either JSON or YAML might mess up with the order in which a user would
> write the configuration.

I wouldn't be much concerned with how a user would write it. As long
as the file is valid JSON/YAML, we should be safe using it.
When it is written it is subject to changes anyway.

If we start considering it a cache, well, I do not even expect the
user to fiddle with it. :-)

> But maybe in the end what we are calling configuration is actually just
> a cache of pre-answered questions instead of an actual configuration
> file ...

It is actually, only two of those values I can call "configuration":
the server and the rpc_endpoint to talk to a remote server.
All the others, not really configuration values.

But still, even for those two, I would not expect to be asked each
time to insert or confirm them. A configuration for me is something
that should not be asked each time.

--
Milo Casagrande | Automation Engineer
Linaro.org <www.linaro.org> │ Open source software for ARM SoCs

« Back to merge proposal