Merge lp:~milo/lava-tool/integration-tests-fixes into lp:~linaro-validation/lava-tool/trunk

Proposed by Milo Casagrande
Status: Merged
Merged at revision: 189
Proposed branch: lp:~milo/lava-tool/integration-tests-fixes
Merge into: lp:~linaro-validation/lava-tool/trunk
Diff against target: 44 lines (+4/-5)
3 files modified
integration-tests.d/lava-job-new-with-config.sh (+2/-2)
integration-tests.d/lava-job-submit.sh (+1/-1)
integration-tests.d/lib/server.py (+1/-2)
To merge this branch: bzr merge lp:~milo/lava-tool/integration-tests-fixes
Reviewer Review Type Date Requested Status
Antonio Terceiro Approve
Linaro Validation Team Pending
Review via email: mp+177637@code.launchpad.net

Description of the change

The merge proposal fixes two integration tests failing.
Changes are explained in more detail in the commits:
- Enabled non "interactiveness" of the command line
- Renamed a parameter
- Changed how the server and rpc_endpoint parameters are treated (this might change again though, since to me it's not clear how they should really be used and the parameter names are generic enough).

To post a comment you must log in.
191. By Milo Casagrande

Corrected server/rpc_endpoint usage.

Revision history for this message
Milo Casagrande (milo) wrote :

Pushed a new change since there is another MP that fixes the logic of the server/rpc_endpoint parameters in the actual lava-tool code.

192. By Milo Casagrande

Added trailing slash support for flask URL.

Revision history for this message
Antonio Terceiro (terceiro) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'integration-tests.d/lava-job-new-with-config.sh'
2--- integration-tests.d/lava-job-new-with-config.sh 2013-05-28 22:08:12 +0000
3+++ integration-tests.d/lava-job-new-with-config.sh 2013-07-31 13:28:30 +0000
4@@ -3,8 +3,8 @@
5 device_type = panda
6
7 [device_type=panda]
8-prebuilt_image = file:///path/to/panda.img
9+image = file:///path/to/panda.img
10 EOF
11-LAVACONFIG="${tmpdir}/config" lava job new "${tmpdir}/job.json"
12+LAVACONFIG="${tmpdir}/config" lava job new "${tmpdir}/job.json" -n
13 cat "${tmpdir}/job.json"
14 grep "device_type.*panda" "${tmpdir}/job.json" && grep "image.*path.to.panda.img" "${tmpdir}/job.json"
15
16=== modified file 'integration-tests.d/lava-job-submit.sh'
17--- integration-tests.d/lava-job-submit.sh 2013-06-03 18:06:49 +0000
18+++ integration-tests.d/lava-job-submit.sh 2013-07-31 13:28:30 +0000
19@@ -8,5 +8,5 @@
20 rpc_endpoint = http://localhost:5000/ok
21 CONFIG
22
23-lava job submit integration-tests.d/sample/nexus.json > $tmpdir/output
24+lava job submit integration-tests.d/sample/nexus.json -n > $tmpdir/output
25 grep "Job submitted with job ID 999" $tmpdir/output
26
27=== modified file 'integration-tests.d/lib/server.py'
28--- integration-tests.d/lib/server.py 2013-06-03 18:06:49 +0000
29+++ integration-tests.d/lib/server.py 2013-07-31 13:28:30 +0000
30@@ -1,5 +1,4 @@
31 import os
32-import sys
33 import yaml
34
35 from flask import (
36@@ -25,7 +24,7 @@
37 request.environ['werkzeug.server.shutdown']()
38 return ""
39
40-@app.route('/<status_code>', methods=['GET', 'POST'])
41+@app.route('/<status_code>/', methods=['GET', 'POST'])
42 def reply(status_code):
43
44 status = int(aliases.get(status_code, status_code))

Subscribers

People subscribed via source and target branches