Code review comment for lp:~milo/lava-dashboard/get-test-names

Revision history for this message
Milo Casagrande (milo) wrote :

On Fri, Sep 21, 2012 at 4:39 PM, Andy Doan <email address hidden> wrote:
> I have one small nitpick. Can you change the method signature from:
>
> def get_tests_names(self, device=None):
>
> to
>
> def get_tests_names(self, device_type=None):
>
> Just to keep the wording of things in code consistent.

Absolutely!
This is now done.

Thanks.

--
Milo Casagrande
Infrastructure Engineer
Linaro.org <www.linaro.org> │ Open source software for ARM SoCs

« Back to merge proposal