Merge lp:~milo/lava-dashboard/bug1052545 into lp:lava-dashboard

Proposed by Milo Casagrande
Status: Merged
Merged at revision: 349
Proposed branch: lp:~milo/lava-dashboard/bug1052545
Merge into: lp:lava-dashboard
Diff against target: 25 lines (+3/-3)
1 file modified
dashboard_app/xmlrpc.py (+3/-3)
To merge this branch: bzr merge lp:~milo/lava-dashboard/bug1052545
Reviewer Review Type Date Requested Status
Linaro Validation Team Pending
Review via email: mp+126468@code.launchpad.net

Description of the change

This branch fixes the use of the wrong filed of the Test model to get the test names. We need to use test_id, not name.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'dashboard_app/xmlrpc.py'
2--- dashboard_app/xmlrpc.py 2012-09-26 13:55:57 +0000
3+++ dashboard_app/xmlrpc.py 2012-09-26 14:45:29 +0000
4@@ -408,7 +408,7 @@
5 'is_deserialized': bundle.is_deserialized
6 } for bundle in bundle_stream.bundles.all().order_by("uploaded_on")]
7
8- @xml_rpc_signature('str', 'str')
9+ @xml_rpc_signature('str')
10 def get_test_names(self, device_type=None):
11 """
12 Name
13@@ -433,10 +433,10 @@
14 for test in Test.objects.filter(
15 test_runs__attributes__name='target.device_type',
16 test_runs__attributes__value=device_type).distinct():
17- test_names.append(test.name)
18+ test_names.append(test.test_id)
19 else:
20 for test in Test.objects.all():
21- test_names.append(test.name)
22+ test_names.append(test.test_id)
23 return test_names
24
25 def deserialize(self, content_sha1):

Subscribers

People subscribed via source and target branches