Merge lp:~milner/landscape-client/enable-preseed into lp:~landscape/landscape-client/trunk
Status: | Merged |
---|---|
Approved by: | Alberto Donato |
Approved revision: | 369 |
Merged at revision: | 370 |
Proposed branch: | lp:~milner/landscape-client/enable-preseed |
Merge into: | lp:~landscape/landscape-client/trunk |
Diff against target: |
175 lines (+73/-28) 4 files modified
debian/landscape-client.config (+19/-16) debian/landscape-client.postinst (+14/-9) debian/landscape-client.templates (+12/-0) debian/po/templates.pot (+28/-3) |
To merge this branch: | bzr merge lp:~milner/landscape-client/enable-preseed |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alberto Donato (community) | Approve | ||
Free Ekanayaka (community) | Approve | ||
Review via email: mp+77994@code.launchpad.net |
Description of the change
Add the server url and the pingserver url into debconf to allow preseeding the landscape-client package.
To test:
# Clean out existing install
sudo apt-get purge landscape-common landscape-client
sudo rm -f /etc/landscape/
# Use debconf-
cat > temp.debconf <<EOF
landscape-client landscape-
landscape-client landscape-
landscape-client landscape-
landscape-client landscape-
landscape-client landscape-
landscape-client landscape-
EOF
sudo debconf-
# Now install the package
sudo dpkg -i landscape-*
# Verify config file was set up correctly
sudo cat /etc/landscape/
Looks good! +1
[1]
REGISTRATION_ PASSWORD= $(get_var_ from_file "registration_ password" "$CONFIGFILE") var_from_ file "url" "$CONFIGFILE") $(get_var_ from_file "ping_url" "$CONFIG_FILE")
+ URL=$(get_
+ PING_URL=
The files uses a mix of tabs and spaces for indentation, it'd be nice to clean it up (maybe as a separate [trivial]).
[2]
+url = ${URL}
+ping_url = ${PING_URL}
Any particular reason to not write also the computer_title, registration_ password and account_name fields to the file?