Merge lp:~mileo/account-payment/7.0 into lp:~account-payment-team/account-payment/6.1

Status: Merged
Approved by: Raphaël Valyi - http://www.akretion.com
Approved revision: 94
Merged at revision: 95
Proposed branch: lp:~mileo/account-payment/7.0
Merge into: lp:~account-payment-team/account-payment/6.1
Diff against target: 97 lines (+14/-12)
1 file modified
account_payment_extension/payment_view.xml (+14/-12)
To merge this branch: bzr merge lp:~mileo/account-payment/7.0
Reviewer Review Type Date Requested Status
Niels Huylebroeck (community) Approve
Review via email: mp+141422@code.launchpad.net
To post a comment you must log in.
lp:~mileo/account-payment/7.0 updated
95. By Luis Felipe Miléo - http://www.kmee.com.br

[MIGR][account_payment_extension][FIX] Disabled views for module install on 7.0; Work in progress

96. By Luis Felipe Miléo - http://www.kmee.com.br

[MIGR][account_payment_extension][FIX] Account Invoice Views

Revision history for this message
Niels Huylebroeck (red15) wrote :

I'm seeing a little bit of trailing whitespace here and there being added, not a big deal but you might want to check your editor settings to minimize these occurances (see line 16-19 on the diff)

review: Approve
Revision history for this message
Niels Huylebroeck (red15) wrote :

I've merged the diff and edited the whitespace at the same time.
You also had set an executing bit on the xml file (removed that as well).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_payment_extension/payment_view.xml' (properties changed: -x to +x)
2--- account_payment_extension/payment_view.xml 2012-11-15 10:33:02 +0000
3+++ account_payment_extension/payment_view.xml 2012-12-28 17:06:22 +0000
4@@ -153,6 +153,7 @@
5 =================================================================================================
6 -->
7 <!--Field partner_bank_id in client invoices has a strange domain: domain="[('partner_id.ref_companies', 'in', [company_id])]"-->
8+
9 <record model="ir.ui.view" id="invoice_form3">
10 <field name="name">account.invoice.form3.payment_type</field>
11 <field name="model">account.invoice</field>
12@@ -163,15 +164,15 @@
13 <field domain="[('partner_id', '=', partner_id)]" name="partner_bank_id" on_change="onchange_partner_bank(partner_bank_id)"/>
14 </field>
15 </field>
16- </record>
17-
18+ </record>
19+
20 <record model="ir.ui.view" id="invoice_form4">
21 <field name="name">account.invoice.form4.payment_type</field>
22 <field name="model">account.invoice</field>
23 <field name="type">form</field>
24 <field name="inherit_id" ref="account.invoice_form"/>
25 <field name="arch" type="xml">
26- <field name="address_invoice_id" position="after">
27+ <field name="fiscal_position" position="after">
28 <field domain="[('company_id', '=', company_id)]" name="payment_type" on_change="onchange_payment_type(payment_type, partner_id)" />
29 </field>
30 </field>
31@@ -183,14 +184,15 @@
32 <field name="type">form</field>
33 <field name="inherit_id" ref="account.invoice_supplier_form"/>
34 <field name="arch" type="xml">
35- <field name="address_invoice_id" position="after">
36+ <field name="fiscal_position" position="after">
37 <field domain="[('company_id', '=', company_id)]" name="payment_type" on_change="onchange_payment_type(payment_type, partner_id)" />
38 </field>
39 </field>
40 </record>
41-
42+
43
44 <!--************ account.move.line extension to show additional fields **********-->
45+ <!--
46 <record model="ir.ui.view" id="payments_move_line_tree">
47 <field name="name">account.payments.move.line.tree</field>
48 <field name="model">account.move.line</field>
49@@ -223,7 +225,7 @@
50 </separator>
51 </field>
52 </record>
53-
54+ -->
55
56 <!--
57 ========================================================================================================
58@@ -345,7 +347,7 @@
59 =========================================================================================
60 PAYMENTS
61 =========================================================================================
62- -->
63+
64 <record id="view_payments_tree" model="ir.ui.view">
65 <field name="name">Payments</field>
66 <field name="model">account.move.line</field>
67@@ -406,8 +408,8 @@
68 </search>
69 </field>
70 </record>
71-
72- <!-- Invoice Payments -->
73+ -->
74+ <!-- Invoice Payments
75 <record model="ir.actions.act_window" id="action_invoice_payments">
76 <field name="name">Invoice payments</field>
77 <field name="res_model">account.move.line</field>
78@@ -417,8 +419,8 @@
79 <field name="domain">[('account_id.type','in',['receivable','payable']),('invoice','&lt;&gt;',False)]</field>
80 </record>
81 <menuitem name="Invoice payments" parent="account_payment.menu_main_payment" action="action_invoice_payments" id="menu_action_invoice_payments" sequence="4"/>
82-
83- <!-- Done Payments -->
84+ -->
85+ <!-- Done Payments
86 <record model="ir.actions.act_window" id="action_done_payments">
87 <field name="name">Done payments</field>
88 <field name="res_model">account.move.line</field>
89@@ -428,6 +430,6 @@
90 <field name="domain">[('account_id.type','in',['receivable','payable']),('invoice','=',False)]</field>
91 </record>
92 <menuitem name="Done payments" parent="account_payment.menu_main_payment" action="action_done_payments" id="menu_action_done_payments" sequence="5"/>
93-
94+ -->
95 </data>
96 </openerp>
97\ No newline at end of file