Merge lp:~mikeycgto/nuvola-player/bugfix1167378 into lp:nuvola-player/2.5.x

Proposed by mikeycgto
Status: Merged
Merged at revision: 664
Proposed branch: lp:~mikeycgto/nuvola-player/bugfix1167378
Merge into: lp:nuvola-player/2.5.x
Diff against target: 22 lines (+7/-2)
1 file modified
data/nuvolaplayer/services/eighttracks/integration.js (+7/-2)
To merge this branch: bzr merge lp:~mikeycgto/nuvola-player/bugfix1167378
Reviewer Review Type Date Requested Status
Jiří Janoušek Approve
Review via email: mp+158924@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jiří Janoušek (fenryxo) wrote :

Please increase version number in /data/nuvolaplayer/services/eighttracks/metadata.conf:

version = 4
version_minor = 1

review: Needs Fixing
Revision history for this message
Jiří Janoušek (fenryxo) wrote :

I've changed policy about service version numbers - service versions will be increased just before release of a service update package from now, so I'm approving this merge proposal.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/nuvolaplayer/services/eighttracks/integration.js'
2--- data/nuvolaplayer/services/eighttracks/integration.js 2013-02-26 15:19:54 +0000
3+++ data/nuvolaplayer/services/eighttracks/integration.js 2013-04-15 13:47:25 +0000
4@@ -62,11 +62,16 @@
5 * Updates current playback state
6 */
7 Integration.prototype.update = function(){
8- var meta = $('#play_area');
9+ var meta = $('#player_box');
10+ var mix = $('#mix_player_details');
11+
12 var song = meta.find('.t').text();
13 var artist = meta.find('.a').text();
14 var album = meta.find('.album .detail').text();
15- var ab_art = meta.find('.cover').attr('src') || null;
16+ var ab_art = mix.find('img').attr('src') || null;
17+
18+ if (ab_art)
19+ ab_art = ab_art.replace(/w=\d+&h=\d+/, 'w=500&h=500');
20
21 var play_button = $j('#player_play_button');
22 var pause_button = $j('#player_pause_button');

Subscribers

People subscribed via source and target branches