Merge lp:~mikemc/ubuntuone-windows-installer/setup-mac into lp:ubuntuone-windows-installer
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Mike McCracken on 2012-06-19 | ||||
| Approved revision: | 124 | ||||
| Merged at revision: | 123 | ||||
| Proposed branch: | lp:~mikemc/ubuntuone-windows-installer/setup-mac | ||||
| Merge into: | lp:ubuntuone-windows-installer | ||||
| Diff against target: |
631 lines (+611/-0) 4 files modified
scripts/README-mac.txt (+69/-0) scripts/data/macapp_template.plist (+12/-0) scripts/data/qt.conf (+2/-0) scripts/setup-mac.py (+528/-0) |
||||
| To merge this branch: | bzr merge lp:~mikemc/ubuntuone-windows-installer/setup-mac | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Brian Curtin (community) | 2012-06-13 | Approve on 2012-06-18 | |
| Alejandro J. Cura (community) | Approve on 2012-06-15 | ||
|
Review via email:
|
|||
Commit Message
- add initial setup-mac.py script to create a hierarchy of application packages ( LP: 1010202 )
Description of the Change
- add initial setup-mac.py script to create a hierarchy of application packages ( LP: 1010202 )
The script requires an installation of py2app from https:/
It creates .app wrappers for ubuntuone-
As we add darwin support, this script and what it generates will change.
See README-mac.txt for information on how to run and how to test that it worked as much as I expect it to. (It doesn't yet generate anything you can double-click to test)
- 121. By Mike McCracken on 2012-06-14
-
reorganize imports, fix many pep8 complaints
- 122. By Mike McCracken on 2012-06-15
-
merge with trunk
- 123. By Mike McCracken on 2012-06-15
-
add valicert .pem
- 124. By Mike McCracken on 2012-06-15
-
standardize docstrings
| Mike McCracken (mikemc) wrote : | # |
> Looks reasonable to me. However, while I don't personally care about this
> part, I know others do -- the imports should be alphabetized.
121 fixed the imports, the other revisions fixed Alejandro's comments from IRC.

Looks reasonable to me. However, while I don't personally care about this part, I know others do -- the imports should be alphabetized.