Merge lp:~mikemc/ubuntuone-windows-installer/setup-mac-add-sd into lp:ubuntuone-windows-installer

Proposed by Mike McCracken
Status: Merged
Approved by: Diego Sarmentero
Approved revision: 125
Merged at revision: 125
Proposed branch: lp:~mikemc/ubuntuone-windows-installer/setup-mac-add-sd
Merge into: lp:ubuntuone-windows-installer
Diff against target: 103 lines (+43/-7)
1 file modified
scripts/setup-mac.py (+43/-7)
To merge this branch: bzr merge lp:~mikemc/ubuntuone-windows-installer/setup-mac-add-sd
Reviewer Review Type Date Requested Status
Diego Sarmentero (community) Approve
dobey (community) Approve
Review via email: mp+114749@code.launchpad.net

Commit message

- Add syncdaemon and storageprotocol to the darwin app package. (LP: #1019142)

Description of the change

- Add syncdaemon and storageprotocol to the darwin app package. (LP: #1019142)

To post a comment you must log in.
Revision history for this message
dobey (dobey) wrote :

Looks ok to me.

review: Approve
Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scripts/setup-mac.py'
2--- scripts/setup-mac.py 2012-06-15 17:13:44 +0000
3+++ scripts/setup-mac.py 2012-07-12 23:06:19 +0000
4@@ -120,8 +120,8 @@
5 use buildout instead."""),
6 ("only-prepare=", None,
7 """Only do expensive stuff for the packages on
8- this list of one or more of 'sso',
9- 'controlpanel', or 'client'.
10+ this list. Can be any of: 'sso',
11+ 'controlpanel', 'client', or 'storage-protocol'.
12 (NOTE: still downloads everything if from-trunk
13 is set)"""),
14 ("source-dir=", None,
15@@ -149,7 +149,7 @@
16
17 if self.only_prepare is None:
18 # default is to do everything:
19- self.only_prepare = "sso, controlpanel, client"
20+ self.only_prepare = "sso, controlpanel, client, storage-protocol"
21
22 def run(self):
23 """Copy, build and munge things to prepare for packaging."""
24@@ -311,19 +311,46 @@
25 # Copying by hand because the install is borked
26 dest_cp = os.path.join(dest_dir, "ubuntuone", "controlpanel")
27 shutil.copytree(os.path.join("ubuntuone", "controlpanel"),
28- dest_cp)
29+ dest_cp)
30
31 u1cp_revno = subprocess.check_output(["bzr", "revno", "."],
32 env=BZR_ENV).strip()
33
34 os.chdir(start_dir)
35
36+ # build and install storage-protocol files
37+ os.chdir(os.path.join(self.source_dir, "ubuntuone-storage-protocol"))
38+ if 'storage-protocol' in self.only_prepare:
39+ print "building ubuntuone-storage-protocol"
40+ log_file_name = os.path.join(INSTALL_DIR,
41+ "storage-protocol-build.log")
42+ with open(log_file_name, 'w') as logfile:
43+ cmd = "python setup.py build"
44+ retval = subprocess.call(cmd,
45+ shell=True,
46+ stderr=subprocess.STDOUT,
47+ stdout=logfile
48+ )
49+ if retval != 0:
50+ print "error running %r in %r. look in %r for details" %\
51+ (cmd, os.getcwd(), logfile.name)
52+
53+ dest_sp = os.path.join(dest_dir, "ubuntuone", "storageprotocol")
54+ shutil.copytree(os.path.join("ubuntuone", "storageprotocol"),
55+ dest_sp)
56+
57+ sp_revno = subprocess.check_output(["bzr", "revno", "."],
58+ env=BZR_ENV).strip()
59+
60+ os.chdir(start_dir)
61+
62 # Create revno file
63 with open(os.path.join("data", "revnos.txt"), "w+") as revnos:
64 revnos.write("ubuntu-sso-client: %s"
65- "ubuntuone-client: %s"
66- "ubuntuone-control-panel: %s" %
67- (sso_revno, u1client_revno, u1cp_revno))
68+ "ubuntuone-client: %s"
69+ "ubuntuone-control-panel: %s"
70+ "ubuntuone-storage-protocol: %s" %
71+ (sso_revno, u1client_revno, u1cp_revno, sp_revno))
72
73 # Copy storage-protocol's pem files
74 shutil.copyfile(os.path.join(self.source_dir,
75@@ -387,6 +414,7 @@
76 'twisted.web.client',
77 'ubuntu_sso.qt',
78 'ubuntu_sso.qt.ui',
79+ 'ubuntuone.storageprotocol',
80 'oauth'],
81 "excludes": ["fsm", "PyQt4.uic"],
82 "frameworks": dylib_paths,
83@@ -451,6 +479,13 @@
84 os.path.join("bin",
85 "ubuntuone-proxy-tunnel.py"))
86
87+ syncdaemon_app_path = do_setup("UbuntuOne Syncdaemon",
88+ True,
89+ "com.ubuntu.one.syncdaemon",
90+ "ubuntuone-syncdaemon",
91+ os.path.join("bin",
92+ "ubuntuone-syncdaemon.py"))
93+
94 control_panel_script = os.path.join("bin", "ubuntuone-control-panel-qt.py")
95 control_panel_app_path = do_setup("UbuntuOne",
96 True,
97@@ -524,5 +559,6 @@
98 copy_helper(sso_login_qt_app_path)
99 copy_helper(sso_login_app_path)
100 copy_helper(proxy_tunnel_app_path)
101+ copy_helper(syncdaemon_app_path)
102
103 print "DONE. see dist/ for the .app."

Subscribers

People subscribed via source and target branches